New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visual brokenness of the Ignore Boards profile area #4907

Merged
merged 6 commits into from Aug 15, 2018

Conversation

Projects
None yet
3 participants
@Yoshi2889
Contributor

Yoshi2889 commented Aug 13, 2018

Signed-off-by: NanoSector rick.2889@gmail.com

Before:
image

After:
image

Fix visual brokenness of the Ignore Boards profile area
Signed-off-by: NanoSector <rick.2889@gmail.com>

@Yoshi2889 Yoshi2889 changed the title from Fix visual brokenness of the Ignore Boards profile area to [WIP] Fix visual brokenness of the Ignore Boards profile area Aug 14, 2018

@Yoshi2889

This comment has been minimized.

Show comment
Hide comment
@Yoshi2889

Yoshi2889 Aug 14, 2018

Contributor

Adding WIP tag because there are more places where this is used.

Contributor

Yoshi2889 commented Aug 14, 2018

Adding WIP tag because there are more places where this is used.

@Gwenwyfar Gwenwyfar added the Theme label Aug 14, 2018

Yoshi2889 added some commits Aug 14, 2018

Simplify the CSS for the boards list and rename it appropriately
Signed-off-by: NanoSector <rick.2889@gmail.com>
Simplify and fix the Profile ignore boards HTML
Signed-off-by: NanoSector <rick.2889@gmail.com>
Simplify and fix the Search ignore boards HTML
Signed-off-by: NanoSector <rick.2889@gmail.com>
@Yoshi2889

This comment has been minimized.

Show comment
Hide comment
@Yoshi2889

Yoshi2889 Aug 14, 2018

Contributor

image

This should do... However it does not work well when on mobile/small resolutions.

Contributor

Yoshi2889 commented Aug 14, 2018

image

This should do... However it does not work well when on mobile/small resolutions.

Only show double columns when the screen width allows for it.
Signed-off-by: NanoSector <rick.2889@gmail.com>

@Yoshi2889 Yoshi2889 changed the title from [WIP] Fix visual brokenness of the Ignore Boards profile area to Fix visual brokenness of the Ignore Boards profile area Aug 14, 2018

@jdarwood007

This comment has been minimized.

Show comment
Hide comment
@jdarwood007
Member

jdarwood007 commented Aug 14, 2018

screen shot 2018-08-13 at 6 08 12 pm

@Yoshi2889

This comment has been minimized.

Show comment
Hide comment
@Yoshi2889

Yoshi2889 Aug 14, 2018

Contributor

I've changed it to a grid, but I'm not sure if I'm happy with this...
image

Contributor

Yoshi2889 commented Aug 14, 2018

I've changed it to a grid, but I'm not sure if I'm happy with this...
image

Fix columns being misaligned (Thanks Gwenwyfar)
Signed-off-by: NanoSector <rick.2889@gmail.com>

@jdarwood007 jdarwood007 merged commit 30b0f5a into SimpleMachines:release-2.1 Aug 15, 2018

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment