New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve smiley visibility on load #4925

Merged
merged 1 commit into from Aug 17, 2018

Conversation

Projects
None yet
2 participants
@sbulen
Contributor

sbulen commented Aug 17, 2018

Fixes #4920

Now displays icon upon initial page load
Stores blanks when forum default selected
Also added check to prevent infinite loops (e.g., if the admin removes your favorite smiley set)

Fix smiley visibility on load
Signed by Shawn Bulen, bulens@pacbell.net

@jdarwood007 jdarwood007 merged commit c3533f8 into SimpleMachines:release-2.1 Aug 17, 2018

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sbulen sbulen deleted the sbulen:smileyfix1 branch Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment