New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mod authors the option to override the id theme without changing the url #5005

Merged
merged 4 commits into from Sep 18, 2018

Conversation

Projects
None yet
4 participants
@tinoest
Contributor

tinoest commented Sep 9, 2018

This is to remove the need to edit the source file of Load.php like TinyPortal currently does when it has a custom theme set on a article, code modification is here; https://github.com/Tinyportal/TinyPortal/blob/master/install.xml#L64

I couldn't seem to get load_theme hook to work correctly as it sets other sections before anything else gets a chance to.

@jdarwood007

This comment has been minimized.

Show comment
Hide comment
@jdarwood007

jdarwood007 Sep 11, 2018

Member

Shouldn't this be a bit more down as otherwise it could get overridden again by a board theme?

Member

jdarwood007 commented Sep 11, 2018

Shouldn't this be a bit more down as otherwise it could get overridden again by a board theme?

@tinoest

This comment has been minimized.

Show comment
Hide comment
@tinoest

tinoest Sep 11, 2018

Contributor

It could be yes, I just went for the same place TP already modifies.

I’ll move it down later today.

Contributor

tinoest commented Sep 11, 2018

It could be yes, I just went for the same place TP already modifies.

I’ll move it down later today.

@Gwenwyfar Gwenwyfar added the Hooks label Sep 11, 2018

@Sesquipedalian Sesquipedalian added this to the RC2 milestone Sep 18, 2018

@Sesquipedalian Sesquipedalian merged commit c5816b0 into SimpleMachines:release-2.1 Sep 18, 2018

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment