New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added icon check for recent fixes #5029 #5032

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
4 participants
@albertlast
Collaborator

albertlast commented Oct 3, 2018

Copy the logic from messageindex:

// We need to check the topic icons exist...
if (!empty($modSettings['messageIconChecks_enable']))
{
if (!isset($context['icon_sources'][$row['first_icon']]))
$context['icon_sources'][$row['first_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['first_icon'] . '.png') ? 'images_url' : 'default_images_url';
if (!isset($context['icon_sources'][$row['last_icon']]))
$context['icon_sources'][$row['last_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['last_icon'] . '.png') ? 'images_url' : 'default_images_url';
}
else
{
if (!isset($context['icon_sources'][$row['first_icon']]))
$context['icon_sources'][$row['first_icon']] = 'images_url';
if (!isset($context['icon_sources'][$row['last_icon']]))
$context['icon_sources'][$row['last_icon']] = 'images_url';
}

issue: #5029

@smfbigguy please test this pr

Added icon check for recent
Signed-off-by: albertlast albertlast@hotmail.de

@albertlast albertlast changed the title from Added icon check for recent to Added icon check for recent fixes #5029 Oct 3, 2018

@smfbigguy

This comment has been minimized.

Show comment
Hide comment
@smfbigguy

smfbigguy Oct 3, 2018

Seems to work. I'll post again if it does not. I went into boards were I use custom icons and no errors so far.

smfbigguy commented Oct 3, 2018

Seems to work. I'll post again if it does not. I went into boards were I use custom icons and no errors so far.

@smfbigguy

This comment has been minimized.

Show comment
Hide comment
@smfbigguy

smfbigguy Oct 3, 2018

No errors from this fix so far

smfbigguy commented Oct 3, 2018

No errors from this fix so far

@Sesquipedalian Sesquipedalian added this to the RC 1 milestone Oct 3, 2018

@jdarwood007 jdarwood007 merged commit af3d3b6 into SimpleMachines:release-2.1 Oct 8, 2018

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment