New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sceditor undo js fixes #5035 #5039

Closed
wants to merge 1 commit into
base: release-2.1
from

Conversation

Projects
None yet
3 participants
@albertlast
Collaborator

albertlast commented Oct 10, 2018

On the issue #5035 i see two ways to fix this:
remove the line or add the file again.

This pr take the last approache.
I guess the disabling of this plugin is somekind of temp solution and files removing and adding
could hurt in the upgrade process...
keep the file and update this when undo is fixed is a good way i guess.

Added sceditor undo js
Signed-off-by: albertlast albertlast@hotmail.de
@Sesquipedalian

This comment has been minimized.

Show comment
Hide comment
@Sesquipedalian

Sesquipedalian Oct 10, 2018

Member

No, adding the plugin back in at this point will only bring back the bug in #4749. We can add it once a fixed version is available from SCEditor, but not until then.

Member

Sesquipedalian commented Oct 10, 2018

No, adding the plugin back in at this point will only bring back the bug in #4749. We can add it once a fixed version is available from SCEditor, but not until then.

@albertlast

This comment has been minimized.

Show comment
Hide comment
@albertlast

albertlast Oct 10, 2018

Collaborator

When I read the config right,
Then the plugin keeps disabled,
Even this files get loaded.

Collaborator

albertlast commented Oct 10, 2018

When I read the config right,
Then the plugin keeps disabled,
Even this files get loaded.

@Sesquipedalian

This comment has been minimized.

Show comment
Hide comment
@Sesquipedalian

Sesquipedalian Oct 10, 2018

Member

Why would we want to load an unused, malfunctioning file?

Member

Sesquipedalian commented Oct 10, 2018

Why would we want to load an unused, malfunctioning file?

@jdarwood007

This comment has been minimized.

Show comment
Hide comment
@jdarwood007

jdarwood007 Oct 10, 2018

Member

I would not mind seeing it readded once samclarke/SCEditor#711 has been fixed. This is the underlaying bug that caused its removal.

The bug seems related to the SCEditor itself having had adaption changes and the plugin not being updated to handle those changes. Basically sounds like the plugin is technically not compatible with SCEditor in its current version.

Member

jdarwood007 commented Oct 10, 2018

I would not mind seeing it readded once samclarke/SCEditor#711 has been fixed. This is the underlaying bug that caused its removal.

The bug seems related to the SCEditor itself having had adaption changes and the plugin not being updated to handle those changes. Basically sounds like the plugin is technically not compatible with SCEditor in its current version.

@Sesquipedalian

This comment has been minimized.

Show comment
Hide comment
@Sesquipedalian

Sesquipedalian Oct 11, 2018

Member

Thanks @jdarwood007. Once the plugin has been fixed and released, I'll be glad to add it back in again.

Member

Sesquipedalian commented Oct 11, 2018

Thanks @jdarwood007. Once the plugin has been fixed and released, I'll be glad to add it back in again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment