New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hooks to silently fail. #5410

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@jdarwood007
Copy link
Member

jdarwood007 commented Feb 10, 2019

This fixes #4926 by adding a context check to allow Package Manager to specify that we are silently ignoring this. This is the simplest of fixes without complex changes to the code to do the correct fixes in preventing reloading settings from being called.

Allow hooks to silently fail.
This fixes #4926 by adding a context check to allow Package Manager to specify that we are silently ignoring this.  This is the simplest of fixes without complex changes to the code to do the correct fixes in preventing reloading settings from being called.

@MissAllSunday MissAllSunday added this to the RC2 milestone Feb 12, 2019

@MissAllSunday MissAllSunday merged commit 1dbcbe5 into SimpleMachines:release-2.1 Feb 12, 2019

2 checks passed

Scrutinizer Analysis: 2 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jdarwood007 jdarwood007 deleted the jdarwood007:fixes4926 branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment