Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloudflare IP Support to the auto detection #5732

Open
wants to merge 2 commits into
base: release-2.1
from

Conversation

Projects
None yet
6 participants
@albertlast
Copy link
Collaborator

commented Jul 11, 2019

I like the idea from https://www.simplemachines.org/community/index.php?topic=532453.0
feel free to decide if this is right or not.

Add Cloudflare IP Support
Signed-off-by: albertlast albertlast@hotmail.de
@tinoest

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Would it not make more sense to have a integration hook for any potential future change then a mod for the custom implementations others use?

@albertlast

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

query string is called very early,
to add here hooks is dangerous.

And cloudflare by his own is very big,
so it's the most common one here.

@jdarwood007

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Check a bit further down in the code, we have support for proxy headers there.

Do it in a better way
Signed-off-by: albertlast albertlast@hotmail.de
@VBGAMER45

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

I think this is a great idea. People will use that service often. And it is great to have support out of the box.

@Kindred-999

This comment has been minimized.

Copy link

commented Jul 11, 2019

According to Arantor, 2.1 already HAS this capability with a switch in the admin/security section

@albertlast

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 11, 2019

but it miss on the auto detection.

@albertlast albertlast changed the title Add Cloudflare IP Support Add Cloudflare IP Support to the auto detection Jul 11, 2019

@sbulen sbulen added the Tweak label Jul 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.