Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install/Uninstall of modification has double-slash for additional theme actions #112

Closed
SugarD-x opened this issue Mar 11, 2019 · 2 comments

Comments

@SugarD-x
Copy link

commented Mar 11, 2019

Description

When installing or uninstalling the modification, if additional themes are installed, the option to affect them includes a double-slash in the path.

Steps to reproduce

  1. Install or uninstall the modification with multiple themes installed.
  2. The path will contain a double-slash for the section where actions are taken against additional themes.

Environment (complete as necessary)

  • Version/Git revision: Latest repository files.
  • Database Type: MySQL
  • Database Version: 8.0.12 - MySQL Community Server - GPL

Additional information/references

For an example:
./Themes/theme1//images/admin/shd

@jdarwood007

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

What are the urls like in your theme settings? I tested this with another theme and it works fine.
Install is fine and no issues. Switching to that theme shows no double slashes in the source code.

The themes urls should not end in /

@SugarD-x

This comment has been minimized.

Copy link
Author

commented Apr 7, 2019

Ah, yes. For some reason just a single setting for the theme had a trailing slash for some reason. (I blame the theme maker). I'll close this then. Thanks!

@SugarD-x SugarD-x closed this Apr 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.