Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes #116

Open
wants to merge 3 commits into
base: smf21
from

Conversation

Projects
None yet
2 participants
@dragomano
Copy link

commented Apr 9, 2019

[] windowbg2 style does not use with SMF 2.1 more.
[
] small fix for undefined index 'name' on Canned Replies area.

Signed-off-by: Bugo bugo@dragomano.ru

dragomano and others added some commits Apr 9, 2019

[*] windowbg2 style does not use with SMF 2.1 more.
[*] small fix for undefined index 'name' on Canned Replies area.

Signed-off-by: Bugo <bugo@dragomano.ru>
"Call to undefined function template_shd_button_strip() " - small fix
Signed-off-by: Bugo <bugo@dragomano.ru>

@jdarwood007 jdarwood007 added the Bugs label Apr 21, 2019

@jdarwood007 jdarwood007 added this to the SMF 2.1 Compatibility milestone Apr 21, 2019

@jdarwood007 jdarwood007 self-requested a review Apr 21, 2019

@jdarwood007

This comment has been minimized.

Copy link
Member

commented Apr 21, 2019

Hi @dragomano ,

Thanks for the fixes. Could you cleanup the changes pointed out in Scrutinizer and this should be good to merge: https://scrutinizer-ci.com/g/SimpleDesk/SimpleDesk/inspections/159787c7-6eeb-4f00-af02-ad1af9c0b370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.