Revamp fix_packages #63
Conversation
Fixes SimpleMachines#57 Fixes SimpleMachines#62
|
FYI I only tested this on 2.0 and 2.1. Didn't test 1.x |
|
I don't recall seeing this request for review earlier. Sorry about that. I'll take a look. I am not actually familiar with this tool or what it does... The one time I tried to figure it out it didn't work with php 8... I thought this wasn't necessary for 2.1??? And, to be honest, I don't want to spend time on anything specific to 2.0, which is in security fix only mode. I'd like to focus all bandwidth on 2.1 going forward. |
|
Some users were trying to use it on 2.1 since it’s valid, but reported it as faulty using php 8 |
|
Can someone tell me what this is supposed to do? 😆 Is there a description anywhere? It's not in the code... I think it's supposed to help you:
Anything else? I actually don't have any 2.0 environments to test anymore... I thought I was done with 2.0... I'm trying to build a 2.0.19 env to test this... |
|
I believe that is what it was designed to do. Fix a broken package where your forum may not otherwise work. |
|
OK, just pulled it up & I suspect a problem. I have 5 packages installed in my test environment. When I pull up the old version, it lists the 5 packages. When I pull up the new version, it lists 0 packages. No errors... Screenshot 1 - old version (php 7.4): Screenshot 2 - new version (php 8.0): Screenshot 3 - 5 packages installed in pacman: |
|
There is a definite issue with how it is calling the list builder. The param is not getting passed properly... isInstalled is false, so it's looking for packages with an installed value of 0. In my simple test, they all have a value of 1, so no packages are returned. |
|
I will try to get around to it soon as I can. |
Fixes #57
Fixes #62