Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase One release for Issue #620 #778

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
2 participants
@jtj9817
Copy link
Contributor

jtj9817 commented Feb 8, 2019

When the application starts, a new Thread is started in the background after checking for PERMISSION_READ_CONTACTS. However, I believe that this can be further improved if Kotlin Coroutines were used instead of the generic Thread lambda function.

jtj9817 added some commits Feb 8, 2019

Feature request for Issue #602
Added a background task that is run using a new Thread when the application starts.
@tibbi

This comment has been minimized.

Copy link
Member

tibbi commented Feb 8, 2019

please stick to the code style used in the project, this looks way off. Thanks

@jtj9817

This comment has been minimized.

Copy link
Contributor Author

jtj9817 commented Feb 11, 2019

I tried to follow the code style used in the project since there's no official cod estyle guide in the README file of the repository. Please tell me how I can improve the code style for this pull request so I can continue working on it. If there's a guideline online that you use that I should also follow, please post it. Thanks!

@tibbi

This comment has been minimized.

Copy link
Member

tibbi commented Feb 11, 2019

it doesnt need to be in the readme, just read the code in other functions and files, for gods sake

Added BirthdaysBackgroundSync function
Similar to tryAddBirthdays() function but bypasses the handlePermission(PERMISSION_READ_CONTACTS) condition because if(hasPermission(PERMISSION_READ_CONTACTS)) already handles it.
@tibbi

This comment has been minimized.

Copy link
Member

tibbi commented Feb 16, 2019

sorry, but this is just getting worse. Thanks for the effort though.

@tibbi tibbi closed this Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.