Skip to content

Allow gradle build without keystore.properties file - #169

Merged
tibbi merged 2 commits into
SimpleMobileTools:masterfrom
spk:fix-build-without-release
Dec 19, 2019
Merged

Allow gradle build without keystore.properties file#169
tibbi merged 2 commits into
SimpleMobileTools:masterfrom
spk:fix-build-without-release

Conversation

@spk

@spk spk commented Dec 18, 2019

Copy link
Copy Markdown
Contributor

Hi o/ this patch allow to build the project after cloning without to have to create a dummy keystore.properties file, cheers!

@tibbi

tibbi commented Dec 19, 2019

Copy link
Copy Markdown
Contributor

I updated it a bit to make less changes, will apply it to all apps soon. Thanks

@tibbi
tibbi merged commit 7bfbe1d into SimpleMobileTools:master Dec 19, 2019
@spk
spk deleted the fix-build-without-release branch December 22, 2019 19:56
@spk

spk commented Dec 22, 2019

Copy link
Copy Markdown
Contributor Author

Thanks for the merge but I got this error with the latest changes:

Could not get unknown property 'release' for SigningConfig container of type org.gradle.api.internal.FactoryNamedDomainObjectContainer.

Re-add part of the patch fix the issue:

--- app/build.gradle
+++ app/build.gradle
@@ -40,7 +40,9 @@ android {
         release {
             minifyEnabled true
             proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
-            signingConfig signingConfigs.release
+            if (keystorePropertiesFile.exists()) {
+                signingConfig signingConfigs.release
+            }
         }
     }

wdyt?

@tibbi

tibbi commented Dec 22, 2019

Copy link
Copy Markdown
Contributor

aha okay, I wasnt aware of that issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants