Skip to content

Take all text scaling into account when determining pagerTabStrip height #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Take all text scaling into account when determining pagerTabStrip height #677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions app/src/main/kotlin/com/simplemobiletools/notes/pro/activities/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,10 @@ class MainActivity : SimpleActivity() {

initViewPager(intent.getLongExtra(OPEN_NOTE_ID, -1L))
binding.pagerTabStrip.drawFullUnderline = false
binding.pagerTabStrip.setTextSize(TypedValue.COMPLEX_UNIT_PX, getPercentageFontSize())
val textSize = getPercentageFontSize()
binding.pagerTabStrip.setTextSize(TypedValue.COMPLEX_UNIT_PX, textSize)
binding.pagerTabStrip.layoutParams.height =
(binding.pagerTabStrip.height + resources.getDimension(com.simplemobiletools.commons.R.dimen.activity_margin) * 2 * (config.fontSizePercentage / 100f)).toInt()
(textSize + resources.getDimension(com.simplemobiletools.commons.R.dimen.medium_margin) * 2).toInt()
(binding.pagerTabStrip.layoutParams as ViewPager.LayoutParams).isDecor = true
checkWhatsNewDialog()
checkIntents(intent)
Expand Down Expand Up @@ -138,7 +139,10 @@ class MainActivity : SimpleActivity() {

refreshMenuItems()
binding.pagerTabStrip.apply {
setTextSize(TypedValue.COMPLEX_UNIT_PX, getPercentageFontSize())
val textSize = getPercentageFontSize()
setTextSize(TypedValue.COMPLEX_UNIT_PX, textSize)
layoutParams.height =
(textSize + resources.getDimension(com.simplemobiletools.commons.R.dimen.medium_margin) * 2).toInt()
setGravity(Gravity.CENTER_VERTICAL)
setNonPrimaryAlpha(0.4f)
setTextColor(getProperPrimaryColor())
Expand Down