New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Client returns QueryResult even if there is a result #1

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@patrickbroens
Contributor

patrickbroens commented Sep 5, 2018

This patch fixes this by returning null when there is no result

[BUGFIX] Client returns QueryResult even if there is a result
This patch fixes this by returning null when there is no result
@radmiraal

This comment has been minimized.

Contributor

radmiraal commented Sep 5, 2018

I'd prefer implementing \Countable and check for the result count being 0 where the result is used. That would keep the API clean.
Either way in this current change the return type should've been nullable.

@patrickbroens patrickbroens deleted the patrickbroens:patch-1 branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment