Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto pypi publish on new release #112

Merged
merged 4 commits into from
May 14, 2023

Conversation

TiansuYu
Copy link
Contributor

@TiansuYu
Copy link
Contributor Author

@gventuri I have written a draft. If you want to test it, you can go add a test pypi person access token as PYPI_TOKEN in github secret (which can be replaced with real ones afterwards) and switch on this section:

#  push:
#    branches:
#      - add-auto-pypi-release

to test the auto-publish.
(Unfortnately, I think the trigger on release will not work unless this yaml is on main.)

After this works, I will remove the testing part and leave only the parts for production.

@gventuri gventuri force-pushed the add-auto-pypi-release branch 10 times, most recently from 097c464 to 82a131b Compare May 11, 2023 17:14
@gventuri
Copy link
Collaborator

@TiansuYu configured everything, but cannot make it work:

There is no pypi-token.test_pypi setting.

This is actually weird, cause we are passing the key

@gventuri
Copy link
Collaborator

@TiansuYu if what the maintainer of the library mentioned is correct, maybe we should test with an actual release with the right repo and see whether it works!

@gventuri gventuri merged commit ac6ed93 into Sinaptik-AI:main May 14, 2023
@TiansuYu
Copy link
Contributor Author

I will come back to this as soon as I can. In the mean time, the PR is not correct from my point of view.

Regarding the action itself. 1) fix according to the action author's suggestions 2) we can write the steps ourselves without the action's help. It is something super simple with github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate pypi release in github actions
2 participants