Skip to content

Use the /proc filesystem on cygwin #7

Merged
merged 1 commit into from Feb 27, 2013

2 participants

@mithun
mithun commented Feb 15, 2013

Cygwin provides a working /proc filesystem that is pretty similar to
Linux distributions. P9Y::ProcessTable::Win32 is updated to recognize
when running on Cygwin and provide the following behavior:

  • Use the /proc filesystem to provide Cygwin process info
  • Use Win32::Process::Info to provide Windows process info

This provides the user with both Cygwin and Windows processes
when on cygwin and only Windows processes when on Win32.

@SineSwiper
Owner

You have a bunch of space changes everywhere. Can you clean that up? (Three spaces, please, or vertical alignment when needed/desired.)

Also, I'm not sure about the win* properties in ::Process. The whole point of P9Y::PT is normalization of this stuff between OSs. What is the specific need for both pids?

@mithun
mithun commented Feb 16, 2013

You have a bunch of space changes everywhere. Can you clean that up? (Three spaces, please, or vertical alignment when needed/desired.)

I usually run code through perltidy. Of course, this is currently setup to my preference. If you have a perltidy config you'd like me to use please let me know. Otherwise I can go thru' and manually fix the indentation.

Also, I'm not sure about the win* properties in ::Process. The whole point of P9Y::PT is normalization of this stuff between OSs. What is the specific need for both pids?

When running under cygwin, both cygwin and Windows assign their own PIDs to the same process - perlcygwin. Under some conditions, users will need either the cygwin pid or windows pid or both. The win* properties are also exposed by Proc::PT under cygwin, so this will help users easily migrate to using P9Y::PT.

@mithun
mithun commented Feb 18, 2013

Fixed indentation to use 3 spaces.

@mithun mithun Use the /proc filesystem on cygwin
Cygwin provides a working /proc filesystem that is pretty similar to
Linux distributions. P9Y::ProcessTable::Win32 is updated to recognize
when running on Cygwin and provide the following behavior:

- Use the /proc filesystem to provide Cygwin process info
- Use Win32::Process::Info to provide Windows process info

This provides the user with both Cygwin and Windows processes
when on cygwin and only Windows processes when on Win32.
9b51815
@SineSwiper
Owner

Well, if P:PT already has it, then I'm cool with using it.

@SineSwiper SineSwiper merged commit 028a5d6 into SineSwiper:master Feb 27, 2013

1 check failed

Details default The Travis build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.