Add sleep, weight and body fat % to Fitbit connector #330

Merged
merged 4 commits into from May 25, 2012

Conversation

Projects
None yet
2 participants
Contributor

kristjan commented May 24, 2012

Handles #299.

@quartzjer can you review for sanity?

kristjan added some commits May 24, 2012

Add FitBit sleep data
And bonus linting

Contributes to #299
Add Fitbit weight and % fat
These synclets could be quite generalized. It would also be beneficial to start
pulling data from `today` and work back towards `memberSince` so that

* Development can get recent data faster - I have years of no measurements
* Users can see recent data immediately

Especially because Fitbit limits clients to 150 calls/hr, it's more important to
get the recent history before the older stuff.

Saying this closes #299
Remove old Fitbit connector
Replaced with the one in lib/services/fitbit
Consolidate Fitbit daily syncs
Now all the logic is encapsulated in `fitbit/lib#dailySync`. The only things
that differ are:

* API endpoint
* Key to check in the response data
* Type of IDR object it is
* IDR path
Contributor

quartzjer commented May 24, 2012

This looks pretty legit, +1, nice!

@kristjan kristjan referenced this pull request May 24, 2012

Closed

Fitbit, pass II #299

kristjan added a commit that referenced this pull request May 25, 2012

Merge pull request #330 from Singly/fitbit
Add sleep, weight and body fat % to Fitbit connector

@kristjan kristjan merged commit 29139ef into master May 25, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment