{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":803343465,"defaultBranch":"main","name":"emscripten","ownerLogin":"SiobhyB","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-05-20T14:42:15.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/2998162?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1716455491.0","currentOid":""},"activityList":{"items":[{"before":"b3b8ffed92bf90e01c8228a6c1d1c6abd8451730","after":null,"ref":"refs/heads/fix/ensure-rename-updates-across-file-systems","pushedAt":"2024-05-23T09:11:31.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"SiobhyB","name":"Siobhan Bamber","path":"/SiobhyB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2998162?s=80&v=4"}},{"before":"92a31bbff13c64f59d47346c977d03789d7cff7d","after":"b3b8ffed92bf90e01c8228a6c1d1c6abd8451730","ref":"refs/heads/fix/ensure-rename-updates-across-file-systems","pushedAt":"2024-05-22T10:41:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"SiobhyB","name":"Siobhan Bamber","path":"/SiobhyB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2998162?s=80&v=4"},"commit":{"message":"refactor: Move oldNode assignment to try block\n\nWith this change, we ensure the assignment doesn't happen if an error is thrown, while also ensuring it runs before the code in the finally block.","shortMessageHtmlLink":"refactor: Move oldNode assignment to try block"}},{"before":"88ede146b067b95304eb69fb1a6ff5d6382a85b4","after":"92a31bbff13c64f59d47346c977d03789d7cff7d","ref":"refs/heads/fix/ensure-rename-updates-across-file-systems","pushedAt":"2024-05-22T08:26:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"SiobhyB","name":"Siobhan Bamber","path":"/SiobhyB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2998162?s=80&v=4"},"commit":{"message":"Merge branch 'main' into fix/ensure-rename-updates-across-file-systems","shortMessageHtmlLink":"Merge branch 'main' into fix/ensure-rename-updates-across-file-systems"}},{"before":"b555a458ad8e8e354ce3c95ce6f0c8c9995814c2","after":"88ede146b067b95304eb69fb1a6ff5d6382a85b4","ref":"refs/heads/fix/ensure-rename-updates-across-file-systems","pushedAt":"2024-05-21T23:27:40.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"SiobhyB","name":"Siobhan Bamber","path":"/SiobhyB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2998162?s=80&v=4"},"commit":{"message":"Merge branch 'main' into fix/ensure-rename-updates-across-file-systems","shortMessageHtmlLink":"Merge branch 'main' into fix/ensure-rename-updates-across-file-systems"}},{"before":"631a8bfd68890fba9f01df3c1f04abb51436b15d","after":"b555a458ad8e8e354ce3c95ce6f0c8c9995814c2","ref":"refs/heads/fix/ensure-rename-updates-across-file-systems","pushedAt":"2024-05-21T23:25:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"SiobhyB","name":"Siobhan Bamber","path":"/SiobhyB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2998162?s=80&v=4"},"commit":{"message":"docs: Update code comment for clarity","shortMessageHtmlLink":"docs: Update code comment for clarity"}},{"before":"7a45fdf3c8fac727b5ab24532cd0f3c365f56e23","after":"631a8bfd68890fba9f01df3c1f04abb51436b15d","ref":"refs/heads/fix/ensure-rename-updates-across-file-systems","pushedAt":"2024-05-21T23:24:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"SiobhyB","name":"Siobhan Bamber","path":"/SiobhyB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2998162?s=80&v=4"},"commit":{"message":"refactor: Don't update nodes if an error is thrown\n\nAs per the feedback here, we don't want to reassign the value if an error is thrown: https://github.com/emscripten-core/emscripten/pull/21964#discussion_r1609037045","shortMessageHtmlLink":"refactor: Don't update nodes if an error is thrown"}},{"before":"f1ca70c0e636290d93bd4b814d58d42318632022","after":"7a45fdf3c8fac727b5ab24532cd0f3c365f56e23","ref":"refs/heads/fix/ensure-rename-updates-across-file-systems","pushedAt":"2024-05-21T21:14:38.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"SiobhyB","name":"Siobhan Bamber","path":"/SiobhyB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2998162?s=80&v=4"},"commit":{"message":"Merge branch 'fix/ensure-rename-updates-across-file-systems' of https://github.com/SiobhyB/emscripten into fix/ensure-rename-updates-across-file-systems","shortMessageHtmlLink":"Merge branch 'fix/ensure-rename-updates-across-file-systems' of <a href=\"https://github.com/SiobhyB/emscripten\">https…</a>"}},{"before":"4139773d6e6f6a6822c7f6e1b5dc4fcbd151d1f4","after":"f1ca70c0e636290d93bd4b814d58d42318632022","ref":"refs/heads/fix/ensure-rename-updates-across-file-systems","pushedAt":"2024-05-21T21:13:34.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"SiobhyB","name":"Siobhan Bamber","path":"/SiobhyB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2998162?s=80&v=4"},"commit":{"message":"Merge branch 'main' into fix/ensure-rename-updates-across-file-systems","shortMessageHtmlLink":"Merge branch 'main' into fix/ensure-rename-updates-across-file-systems"}},{"before":"ad46580fe0251fc1c3d04b61864501a88496de8b","after":"4139773d6e6f6a6822c7f6e1b5dc4fcbd151d1f4","ref":"refs/heads/fix/ensure-rename-updates-across-file-systems","pushedAt":"2024-05-21T21:07:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"SiobhyB","name":"Siobhan Bamber","path":"/SiobhyB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2998162?s=80&v=4"},"commit":{"message":"refactor: Remove redundant/duplicated code\n\nAs we're now calling `old_node.parent = new_dir` from the `finally` block in library_fs.js, it's not necessary to duplicate that line in MEMFS or PROXYFS.","shortMessageHtmlLink":"refactor: Remove redundant/duplicated code"}},{"before":"3cb838d3873fe7542f3f1a046e2d73cc488c2288","after":"ad46580fe0251fc1c3d04b61864501a88496de8b","ref":"refs/heads/fix/ensure-rename-updates-across-file-systems","pushedAt":"2024-05-21T21:06:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"SiobhyB","name":"Siobhan Bamber","path":"/SiobhyB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2998162?s=80&v=4"},"commit":{"message":"docs: Update code comment for correctness","shortMessageHtmlLink":"docs: Update code comment for correctness"}},{"before":"0efd61b471efe9c1162619a47d5f9f0530aa8aa9","after":"3cb838d3873fe7542f3f1a046e2d73cc488c2288","ref":"refs/heads/fix/ensure-rename-updates-across-file-systems","pushedAt":"2024-05-20T21:30:36.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"SiobhyB","name":"Siobhan Bamber","path":"/SiobhyB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2998162?s=80&v=4"},"commit":{"message":"Merge branch 'main' into fix/ensure-rename-updates-across-file-systems","shortMessageHtmlLink":"Merge branch 'main' into fix/ensure-rename-updates-across-file-systems"}},{"before":null,"after":"0efd61b471efe9c1162619a47d5f9f0530aa8aa9","ref":"refs/heads/fix/ensure-rename-updates-across-file-systems","pushedAt":"2024-05-20T14:42:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"SiobhyB","name":"Siobhan Bamber","path":"/SiobhyB","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2998162?s=80&v=4"},"commit":{"message":"Ensure parent directory is updated in rename()\n\nAdd a fallback update to the parent directory reference in the finally block of the rename function to ensure consistency. This change addresses cases where the node_ops.rename update doesn't propagate across different file systems or mount points, ensuring that the parent directory reference is correctly updated.","shortMessageHtmlLink":"Ensure parent directory is updated in rename()"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUc28AwA","startCursor":null,"endCursor":null}},"title":"Activity · SiobhyB/emscripten"}