Skip to content

Commit

Permalink
Create .editorconfig
Browse files Browse the repository at this point in the history
  • Loading branch information
Jonas Platte committed Jul 4, 2016
1 parent b658b46 commit e55e5cc
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions .editorconfig
View file
@@ -0,0 +1,22 @@
# For the full list of code style requirements, see CONTRIBUTING.md

root = true

[*]
charset = utf-8
end_of_line = lf

[*.{c,h,cmake,txt}]
indent_style = tab
indent_size = 4

This comment has been minimized.

Sign in to view

Copy link
@mikkeloscar

mikkeloscar Jul 7, 2016

Collaborator

This changes how my editor (and github) shows tabs. I don't think that is right, can we omit the ident_size here or at least make it 8 (which is what the kernel style defines)?

This comment has been minimized.

Sign in to view

Copy link
@jplatte

jplatte Jul 7, 2016

Yeah, if you actually want to use 8 space wide tabs, I'd say the best solution is to omit this option. I first thought 4 spaces was what @SirCmpwn preferred because it looked like CONTRIBUTING.md had 4 space indentation in the code block. Apparently that was just how GitHub renders tabs in markdown code blocks regardless of any setting.

My personal motivation for this PR was more or less this line because I find 8 space wide indentation hideous and wanted to have less indentation per tab when reading through the source on GitHub. But if 8 space indentation is actually what you and SirCmpwn prefer, so be it.

This comment has been minimized.

Sign in to view

Copy link
@ddevault

ddevault Jul 7, 2016 •
edited

Member

I use 4 spaces-wide tabs. It doesn't matter how wide the tabs are in your editor, idgaf. I'll let you know if your lines are too long during PR review.

[*.{xml,yml}]
indent_style = space
indent_size = 2

[config]
indent_style = space
indent_size = 4

[*.md]
trim_trailing_whitespace = false

0 comments on commit e55e5cc

Please sign in to comment.