Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated unit tests needed for XConnect Foundation and Features #392

Closed
nickwesselman opened this Issue Jun 14, 2018 · 0 comments

Comments

Projects
1 participant
@nickwesselman
Copy link
Collaborator

nickwesselman commented Jun 14, 2018

  • Feature / Account
  • Feature / Demo
  • Foundation / Account
  • Foundation / SitecoreExtensions

@nickwesselman nickwesselman added the v9 label Jun 14, 2018

@nickwesselman nickwesselman added this to To do in Release for Sitecore 9.0 via automation Jun 14, 2018

nickwesselman added a commit that referenced this issue Jun 15, 2018

[#385] updated remaining Sitecore 8.2 references, removed obsolete 8.…
…2 reference

* the latter further broke SitecoreExtensions tests, so they were removed (see #392)

@nickwesselman nickwesselman self-assigned this Jun 20, 2018

@nickwesselman nickwesselman moved this from To do to In progress in Release for Sitecore 9.0 Jun 20, 2018

nickwesselman added a commit that referenced this issue Jun 28, 2018

[#392] started fixup of Feature / Demo unit tests
* still excluded from solution, may just remove these as Demo feature likely belongs in Habitat Home

nickwesselman added a commit that referenced this issue Jun 28, 2018

[#392] some changes to make UpdateContactFacetsService testable and b…
…etter covered

* added Feature / Accounts tests back, **several test classes have compilation disabled still**
* Introduced IContactManagerService to work around ContactManager testability (lack of)
* Introduced IXdbContextFactory to allow mocking IXdbContext / client
* Split facet updates into their own services to make their logic more easily tested

nickwesselman added a commit that referenced this issue Jun 28, 2018

[#392] fixed up Feature/Accounts AccountsControllerTests
* intention of all failing tests wasn't clear -- looked like some test cases that were no longer relevant, but hard to tell because history is a bit munged

nickwesselman added a commit that referenced this issue Jun 29, 2018

[#392] reintroduced Feature/Demo and fixed up its tests, refactoring …
…as needed

* introduced interfaces for a number of services to facilitate mocking

Release for Sitecore 9.0 automation moved this from In progress to Done Jun 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.