New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release build is broken (1.6 / Sitecore 9.0 Update-2) #435

Closed
nickwesselman opened this Issue Jul 20, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@nickwesselman
Collaborator

nickwesselman commented Jul 20, 2018

Describe the bug
Habitat cannot currently build in the Release configuration:

src\Foundation\Dictionary\tests\Services\CreateDictionaryEntryServiceTests.cs(29,30): Error CS0122: 'CreateDictionaryEntryService' is inaccessible due to its protection level

Sitecore Version
Sitecore 9.0 Update-2

To Reproduce

  1. Clone repo
  2. Switch to Release build
  3. Build

Expected behavior
Successful build

Additional context
CreateDictionaryEntryServiceTests is testing the internal marked CreateDictionaryEntryService. However the InternalsVisibleTo assembly property is conditional to DEBUG only.

@nickwesselman nickwesselman added the bug label Jul 20, 2018

@BenMurphy1994

This comment has been minimized.

BenMurphy1994 commented Oct 23, 2018

Any update on this bug?

@nickwesselman

This comment has been minimized.

Collaborator

nickwesselman commented Oct 23, 2018

Hi @BenMurphy1994 -- Release build not typically needed for Habitat, as it is an example reference intended for deployment in local development environments, so this is not currently a high priority. It will likely be addressed when Habitat is released for the next major release of Sitecore itself. Is there a specific use case that this is blocking for you?

It can easily be worked around by disabling compilation of Foundation.Dictionary.Tests in the Release build configuration, or removing the conditional compilation on the InternalsVisibleTo.

@BenMurphy1994

This comment has been minimized.

BenMurphy1994 commented Oct 23, 2018

Nothing major, just looking to demo an Azure Sitecore site to a client. Using habitat as the demo site and releasing through Azure DevOps as a personal training objective.

Okay thank you, will remove from the Release build config. Thanks for the reply!

@nickwesselman

This comment has been minimized.

Collaborator

nickwesselman commented Oct 23, 2018

Sounds good. For demo purposes you should just be able to use a Debug build as well I would think.

nickwesselman added a commit that referenced this issue Nov 27, 2018

[#435] fix Release build
* no real reason to limit InternalsVisibleTo to Debug build, may want to run tests in Release build
@nickwesselman

This comment has been minimized.

Collaborator

nickwesselman commented Nov 28, 2018

Resolved in Habitat 1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment