New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/migrate gulp to cake #55

Merged
merged 3 commits into from Sep 4, 2018

Conversation

Projects
None yet
2 participants
@kimcu-on-thenet
Copy link
Contributor

kimcu-on-thenet commented Aug 30, 2018

New Feature Submissions:

  1. Migrate the build/deploy script from gulp to Cake
  2. Remove all the gulp stuffs
  3. This relates to issue #30
@jeanfrancoislarente
Copy link
Collaborator

jeanfrancoislarente left a comment

Fantastic work. Just minor questions/comments along the way.
Once you respond I'll try to give this a shot.

build.cake Outdated
.SetVerbosity(Verbosity.Minimal)
.SetMSBuildPlatform(MSBuildPlatform.Automatic)
.SetPlatformTarget(PlatformTarget.MSIL)
.UseToolVersion(MSBuildToolVersion.VS2017));

This comment has been minimized.

@jeanfrancoislarente

jeanfrancoislarente Aug 30, 2018

Collaborator

We should make MSBuiildToolsVersion a configuration item?

This comment has been minimized.

@kimcu-on-thenet

kimcu-on-thenet Aug 31, 2018

Author Contributor

Cake team defines MSBuildToolVersion under enum type. So, I think we use the string value (ie. VS2017) in the configuration, then parse it into MSBuildToolVersion enum type. Please see the change in next commit. Also here is the definition of this enum - https://cakebuild.net/api/Cake.Common.Tools.MSBuild/MSBuildToolVersion/

build.cake Outdated
CleanDirectories($"{configuration.SourceFolder}/**/bin");
});

Task("Nuget-Restore").Does(() => NuGetRestore(configuration.SolutionFile));

This comment has been minimized.

@jeanfrancoislarente

jeanfrancoislarente Aug 30, 2018

Collaborator

Currently working on the new csproj format & msbuild. Looks like nuget restore is causing some issues. Instead we should switch to the /restore flag during msbuild task.

This comment has been minimized.

@kimcu-on-thenet

kimcu-on-thenet Aug 31, 2018

Author Contributor

Thanks for pointing out! I'll use restore flag instead. Please see in next commit

build.cake Outdated
});

/*===============================================
================= HELPER METHODS ================

This comment has been minimized.

@jeanfrancoislarente

jeanfrancoislarente Aug 30, 2018

Collaborator

Is it possible w/ Cake to move Helper methods to another file, to keep things cleaner?

This comment has been minimized.

@kimcu-on-thenet

kimcu-on-thenet Aug 31, 2018

Author Contributor

Yes, Cake supports this function. I'll move those methods to another file. Please see in next commit

README.md Outdated

1. Browse to https://habitathome.dev.local (or whatever hostname you selected)
1. You should see the Habitat Home landing page with a full-width carousel
2. If you do not see the full-width carousel and instead see the initial Sitecore default landing page, ensure that your Host Name was configured correctly in `/sitecore/content/Habitat Sites/Habitat Home/Settings/Site Grouping/Habitat Home`
1. Browse to https://habitat.dev.local
2. Browse to https://habitat.dev.local

This comment has been minimized.

@jeanfrancoislarente

jeanfrancoislarente Aug 30, 2018

Collaborator

We need to change this to https://habitathome.dev.local - looks like it was wrong in the main README.

This comment has been minimized.

@kimcu-on-thenet

kimcu-on-thenet Aug 31, 2018

Author Contributor

I saw you've already changed in develop branch. It's on my branch already

Show resolved Hide resolved build.ps1

@kimcu-on-thenet kimcu-on-thenet force-pushed the kimcu-on-thenet:features/Migrate-Gulp-to-Cake branch 2 times, most recently from c1ace81 to bdb8791 Aug 31, 2018

@kimcu-on-thenet

This comment has been minimized.

Copy link
Contributor Author

kimcu-on-thenet commented Aug 31, 2018

Hi @jeanfrancoislarente

I've added a commit into this pull-request. Please find at e5b2fc8

@kimcu-on-thenet kimcu-on-thenet force-pushed the kimcu-on-thenet:features/Migrate-Gulp-to-Cake branch 2 times, most recently from ed91eb3 to cc5d896 Aug 31, 2018

Refactor:
- Remove NugetRestore task, use the WithRestore instead while building
the solution
- Enable for configuring MSBuildToolVersions (i.e VS2017) from json
config file
- Enable for configuring RunCleanBuilds flag
- Move out helper methods in to another file

@kimcu-on-thenet kimcu-on-thenet force-pushed the kimcu-on-thenet:features/Migrate-Gulp-to-Cake branch from cc5d896 to e5b2fc8 Aug 31, 2018

@jeanfrancoislarente
Copy link
Collaborator

jeanfrancoislarente left a comment

Deployed locally. Worked like a charm

@jeanfrancoislarente jeanfrancoislarente merged commit a22f35a into Sitecore:develop Sep 4, 2018

jeanfrancoislarente added a commit that referenced this pull request Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment