New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing SQL users/passwords and security keys. #24

Merged
merged 1 commit into from Aug 23, 2018

Conversation

Projects
None yet
3 participants
@jflheureux
Copy link
Contributor

jflheureux commented Aug 22, 2018

  • Add missing SQL users/passwords in configuration for systems where the password policy is more strict.
  • Move SQL collection user and password from xConnect to SQL configuration.
  • Add configurable Sitecore password and various encryption keys.
  • Fix a bug where the shell location switched to SQLSERVER:/ when enabling contained databases.
  • Fix a bug where the collectionuser was not dropped from SQL at uninstall due to a comma between arguments.
  • Remove not needed variable assignments in XP/install/set-installation-overrides.ps1.example.
@jammykam
Copy link

jammykam left a comment

The overrides script throws an error due to a variable assignment being removed. This needs to be added in. Also see comments about assignment of passwords using a variable,

$sql.exmMasterUser = $site.prefix + "exmmasteruser"
$sql.exmMasterPassword = "Test12345"
$sql.messagingUser = $site.prefix + "messaginguser"
$sql.messagingPassword = "Test12345"

This comment has been minimized.

@jammykam

jammykam Aug 23, 2018

I would suggest setting the default password in a variable and then assign it, e.g.

$sharedSqlPassword = "Test12345"
$sql.corePassword = $sharedSqlPassword
$sql.masterPassword = $sharedSqlPassword
# ... etc ...

This will mean only a single variable needs to be changed if someone is using the same password for all SQL databases, yet allow them to individually set each database if required.

This comment has been minimized.

@jeanfrancoislarente

jeanfrancoislarente Aug 23, 2018

Collaborator

Good suggestion @jammykam - when I get to playing with the scripts again I'll make that change, unless @jflheureux gets to it first :)

$sql.exmMasterUser = $site.prefix + "exmmasteruser"
$sql.exmMasterPassword = "Test12345"
$sql.messagingUser = $site.prefix + "messaginguser"
$sql.messagingPassword = "Test12345"

This comment has been minimized.

@jammykam

jammykam Aug 23, 2018

See other suggested changes in overrides file to assignment passwords using a (common) variable. Suggest the same is done here.


# Solr Parameters
$solr = $json.settings.solr
$solr.url = "https://localhost:8983/solr"
$solr.root = "c:\solr\solr-6.6.2"
$solr.serviceName = "Solr-6.6.2"


$sql = $json.settings.sql

This comment has been minimized.

@jammykam

jammykam Aug 23, 2018

The $sql = $json.settings.sql assignment needs to be added back in. Without this the ps script fails at this point.

This comment has been minimized.

@jflheureux

jflheureux Aug 23, 2018

Contributor

Absolutely right. Thanks @jeanfrancoislarente for adding it back and merging.

@jeanfrancoislarente jeanfrancoislarente merged commit f616b5d into Sitecore:develop Aug 23, 2018

@jeanfrancoislarente

This comment has been minimized.

Copy link
Collaborator

jeanfrancoislarente commented Aug 23, 2018

Merci @jflheureux - fixed the setting and merged

@jeanfrancoislarente

This comment has been minimized.

Copy link
Collaborator

jeanfrancoislarente commented Aug 23, 2018

Thanks for reviewing @jammykam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment