New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing SQL users/passwords and security keys. #24
Add missing SQL users/passwords and security keys. #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overrides script throws an error due to a variable assignment being removed. This needs to be added in. Also see comments about assignment of passwords using a variable,
$sql.exmMasterUser = $site.prefix + "exmmasteruser" | ||
$sql.exmMasterPassword = "Test12345" | ||
$sql.messagingUser = $site.prefix + "messaginguser" | ||
$sql.messagingPassword = "Test12345" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest setting the default password in a variable and then assign it, e.g.
$sharedSqlPassword = "Test12345"
$sql.corePassword = $sharedSqlPassword
$sql.masterPassword = $sharedSqlPassword
# ... etc ...
This will mean only a single variable needs to be changed if someone is using the same password for all SQL databases, yet allow them to individually set each database if required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion @jammykam - when I get to playing with the scripts again I'll make that change, unless @jflheureux gets to it first :)
$sql.exmMasterUser = $site.prefix + "exmmasteruser" | ||
$sql.exmMasterPassword = "Test12345" | ||
$sql.messagingUser = $site.prefix + "messaginguser" | ||
$sql.messagingPassword = "Test12345" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other suggested changes in overrides file to assignment passwords using a (common) variable. Suggest the same is done here.
|
||
# Solr Parameters | ||
$solr = $json.settings.solr | ||
$solr.url = "https://localhost:8983/solr" | ||
$solr.root = "c:\solr\solr-6.6.2" | ||
$solr.serviceName = "Solr-6.6.2" | ||
|
||
|
||
$sql = $json.settings.sql |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The $sql = $json.settings.sql
assignment needs to be added back in. Without this the ps script fails at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely right. Thanks @jeanfrancoislarente for adding it back and merging.
Merci @jflheureux - fixed the setting and merged |
Thanks for reviewing @jammykam |
SQLSERVER:/
when enabling contained databases.XP/install/set-installation-overrides.ps1.example
.