Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatiblity with Visual Studio 2019 #88

Closed
rroman81 opened this issue Dec 13, 2018 · 31 comments

Comments

Projects
None yet
8 participants
@rroman81
Copy link

commented Dec 13, 2018

I noticed that VS2019 marketplace does not have this extension. Any plans around VS2019 support?

I have a version VS2019 preview on my developer VM, so for now my plan is to pull the code down and recompile with VS2019 sdk. I'd love to help out, so any guidance what needs to be done to ensure that we have VS2019 support ironed out.

@nickwesselman

This comment has been minimized.

Copy link
Collaborator

commented Jan 22, 2019

No explicit plans at this time for us to work on this. I would happily review a PR for VS2019 support.

@rroman81

This comment has been minimized.

Copy link
Author

commented Jan 22, 2019

Noted. I need to add some VS SDK and attempt to recompile the extension.

@rroman81 rroman81 closed this Jan 22, 2019

@nickwesselman

This comment has been minimized.

Copy link
Collaborator

commented Jan 22, 2019

I'm going to reopen this as it should be on the backlog either way. :)

@nickwesselman

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

It appears that in addition to updating metadata, we have some startup changes to make. Currently get some undesirable messaging on startup in VS19:
image

More info:
https://docs.microsoft.com/en-us/visualstudio/extensibility/synchronously-autoloaded-extensions?view=vs-2019
https://github.com/Microsoft/VSSDK-Extensibility-Samples/tree/master/AsyncPackageMigration

@rroman81

This comment has been minimized.

Copy link
Author

commented Apr 10, 2019

i have a branch that's kind of working but do concur that we need to rever to using the AsyncPackage class. That is still pending.

@nickwesselman

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

I'm in progress on it now, moving to AsyncPackage required a cascade of other changes but I think I'm on track.

@nickwesselman nickwesselman self-assigned this Apr 10, 2019

nickwesselman added a commit that referenced this issue Apr 11, 2019

nickwesselman added a commit that referenced this issue Apr 11, 2019

[#88] remove all Toolbox additions because of startup issues with VS1…
…9, especially when debugging, and WebForms being all but entirely deprecated

nickwesselman added a commit that referenced this issue Apr 11, 2019

nickwesselman added a commit that referenced this issue Apr 11, 2019

@rroman81

This comment has been minimized.

Copy link
Author

commented Apr 13, 2019

@nickwesselman Looks like you took the updates a bit further than my branch. Do you want me to test the PR?

@nickwesselman

This comment has been minimized.

Copy link
Collaborator

commented Apr 15, 2019

@rroman81 Feel free but my last test before I had to take off for the weekend included VS17 hard crashing.😆 ... latest PR build should always be available on AppVeyor though:
https://ci.appveyor.com/project/nickwesselman/sitecore-rocks

nickwesselman added a commit that referenced this issue Apr 15, 2019

@nickwesselman

This comment has been minimized.

Copy link
Collaborator

commented Apr 15, 2019

nickwesselman added a commit that referenced this issue Apr 17, 2019

[#88] Version / Targeting Updates
* Update VS targeting to just n-1 (VS17 and V19)
* Update .NET Framework target to 4.7.2
* Ensure appveyor versioning of artifacts and VSIX reflects new major version
* Removed version references from assembly info and VSIX so they don't need to be updated in the future
* Attempt to get appveyor to update assembly versions too

nickwesselman added a commit that referenced this issue Apr 17, 2019

nickwesselman added a commit that referenced this issue Apr 17, 2019

nickwesselman added a commit that referenced this issue Apr 17, 2019

nickwesselman added a commit that referenced this issue Apr 17, 2019

nickwesselman added a commit that referenced this issue Apr 17, 2019

[#88] Version / Targeting Updates
* Update VS targeting to just n-1 (VS17 and V19)
* Update .NET Framework target to 4.7.2
* Ensure appveyor versioning of artifacts and VSIX reflects new major version
* Removed version references from assembly info and VSIX so they don't need to be updated in the future
* Attempt to get appveyor to update assembly versions too

nickwesselman added a commit that referenced this issue Apr 17, 2019

nickwesselman added a commit that referenced this issue Apr 17, 2019

nickwesselman added a commit that referenced this issue Jun 4, 2019

nickwesselman added a commit that referenced this issue Jun 4, 2019

nickwesselman added a commit that referenced this issue Jun 4, 2019

[#88] Version / Targeting Updates
* Update VS targeting to just n-1 (VS17 and V19)
* Update .NET Framework target to 4.7.2
* Ensure appveyor versioning of artifacts and VSIX reflects new major version
* Removed version references from assembly info and VSIX so they don't need to be updated in the future
* Attempt to get appveyor to update assembly versions too

nickwesselman added a commit that referenced this issue Jun 4, 2019

nickwesselman added a commit that referenced this issue Jun 4, 2019

[#88] revert references and VSIX manifest to enable support back to V…
…S2015

* encountered stats that indicate VS2015 usage may still be significant, especially in highly regulated environments

nickwesselman added a commit that referenced this issue Jun 4, 2019

[#88] Ensure TemplateWizard always has 1.0.0.0 version
* Set up shared assembly info between Rocks assemblies, and one shared assembly version which Appveyor can update
* Create new globals solution folder for these and other items that were in 'docs'

nickwesselman added a commit that referenced this issue Jun 4, 2019

nickwesselman added a commit that referenced this issue Jun 4, 2019

[#88] remove all Toolbox additions because of startup issues with VS1…
…9, especially when debugging, and WebForms being all but entirely deprecated

nickwesselman added a commit that referenced this issue Jun 4, 2019

nickwesselman added a commit that referenced this issue Jun 4, 2019

nickwesselman added a commit that referenced this issue Jun 4, 2019

[#88] Version / Targeting Updates
* Update VS targeting to just n-1 (VS17 and V19)
* Update .NET Framework target to 4.7.2
* Ensure appveyor versioning of artifacts and VSIX reflects new major version
* Removed version references from assembly info and VSIX so they don't need to be updated in the future
* Attempt to get appveyor to update assembly versions too

nickwesselman added a commit that referenced this issue Jun 4, 2019

nickwesselman added a commit that referenced this issue Jun 4, 2019

[#88] revert references and VSIX manifest to enable support back to V…
…S2015

* encountered stats that indicate VS2015 usage may still be significant, especially in highly regulated environments

nickwesselman added a commit that referenced this issue Jun 4, 2019

[#88] Ensure TemplateWizard always has 1.0.0.0 version
* Set up shared assembly info between Rocks assemblies, and one shared assembly version which Appveyor can update
* Create new globals solution folder for these and other items that were in 'docs'
@nickwesselman

This comment has been minimized.

Copy link
Collaborator

commented Jun 4, 2019

Sorry for the commit spam on this issue, juggling both adding support for next version of Sitecore and support for VS19. Wanted to get this back on master where AppVeyor can successfully build.

@lizzyCoder @lleopereira @scavezze and all, please try this latest build:
https://ci.appveyor.com/api/buildjobs/p654icv8h1mrqlo2/artifacts/src%2FSitecore.Rocks.VisualStudio%2Fbin%2FRelease%2FSitecore.Rocks.VisualStudio.vsix

I believe I resolved the issue with the TemplateWizard. The VS templates are looking for a specific version of that assembly (1.0.0.0), which I still had in the GAC but that was no longer included in the VSIX, due to enabling of auto-versioning in AppVeyor. Long story short, this build should install the right version in the GAC, or allow you to place the correct version in PublicAssemblies if GAC install fails.

@lizzyCoder

This comment has been minimized.

Copy link

commented Jun 6, 2019

Ok I am getting errors:
When I try to do a new connection under Extensions > Sitecore I get this
image

When I try to open the Sitecore Explorer I get this
image

I did see that the new build does install the TemplateWizard in the publicAssemblies folder.

@nickwesselman

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

@lizzyCoder Yikes, I am definitely not seeing that. Can you perhaps try uninstalling/reinstalling and if it's still erroring, provide the output of Help > About > Copy Info?

@lizzyCoder

This comment has been minimized.

Copy link

commented Jun 7, 2019

Yup! Uninstalling and reinstalling worked. I'm connected now. Thank you for getting this to work!

nickwesselman added a commit that referenced this issue Jun 7, 2019

[#88] Ensure TemplateWizard always has 1.0.0.0 version
* Set up shared assembly info between Rocks assemblies, and one shared assembly version which Appveyor can update
* Create new globals solution folder for these and other items that were in 'docs'

(cherry picked from commit 559c0fa)

# Conflicts:
#	appveyor.yml
#	src/Sitecore.Rocks.Server/Properties/AssemblyInfo.cs
#	src/Sitecore.Rocks.TemplateWizard/Properties/AssemblyInfo.cs
#	src/Sitecore.Rocks.TemplateWizard/Sitecore.Rocks.TemplateWizard.csproj
#	src/Sitecore.Rocks.VisualStudio/Properties/AssemblyInfo.cs
#	src/Sitecore.Rocks/Properties/AssemblyInfo.cs

nickwesselman added a commit that referenced this issue Jun 26, 2019

Merge pull request #111 from Sitecore/feature/88/Visual-Studio-2019-9.2
[Closes #88] Add Visual Studio 2019 Support
@jnegron357

This comment has been minimized.

Copy link

commented Jul 8, 2019

How do I install this for VS2019? I understand it's not released yet but I'd like to give it a test run. When I try the normal install with the VSIX I only get VS2017 option as a target.

@lizzyCoder

This comment has been minimized.

Copy link

commented Jul 8, 2019

@jnegron357 I think VS2019 should be closed first, then try running the installer again.

@nickwesselman

This comment has been minimized.

Copy link
Collaborator

commented Jul 19, 2019

Complete in develop, will be in next Rocks release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.