Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] use Object.entries instead of Object.keys().foreach() #220

Closed
jlast opened this issue Jul 22, 2019 · 1 comment
Closed

[Angular] use Object.entries instead of Object.keys().foreach() #220

jlast opened this issue Jul 22, 2019 · 1 comment

Comments

@jlast
Copy link
Contributor

@jlast jlast commented Jul 22, 2019

In the angular link directives:
*scLink
*scRouterLink
*scGenericLink

Instead of Object.keys().foreach() we would rather use Object.entries, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries

tslib is set on es2017 so entries should be available , https://github.com/Sitecore/jss/blob/dev/packages/sitecore-jss-angular/tsconfig.json

The reason to change is this is because Entries are way more flexibel than keys.

@sc-dawidrutkowski

This comment has been minimized.

Copy link
Collaborator

@sc-dawidrutkowski sc-dawidrutkowski commented Oct 9, 2019

Done in #274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.