Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for TypeScript when 'jss build'ing #146

Merged
merged 1 commit into from Sep 26, 2019

Conversation

@boro2g
Copy link
Contributor

boro2g commented Jan 30, 2019

I've not added in

config.module.rules.push({
    test: /\.(ts|tsx)?$/,
    loader: 'ts-loader',
    exclude: /node_modules/,
    options: {
      appendTsSuffixTo: [/\.vue$/],
    }
  });

as I figured people probably wanted to opt into that.

If adding ^ we'd need to update package.json / package-lock.json with ts-loader and typescript and also add to webpack override: config.resolve.extensions.push('.ts');

@sc-dawidrutkowski sc-dawidrutkowski merged commit 82c34c6 into Sitecore:dev Sep 26, 2019
1 check passed
1 check passed
Sitecore.jss Build #20190130.1 succeeded
Details
@sc-dawidrutkowski

This comment has been minimized.

Copy link
Collaborator

sc-dawidrutkowski commented Sep 26, 2019

@boro2g I've merged your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.