Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log pathRewriteExcludePredicate in debug env #151

Merged
merged 2 commits into from Mar 5, 2019

Conversation

@jlast
Copy link
Contributor

commented Feb 7, 2019

Readd !noDebug to jss-proxy console logging to allow disabling of logging.

Description

Readd !noDebug to jss-proxy console logging to allow disabling of logging.

Motivation

Since the last upgrade we have debug logging on production. This merge request solves it.

How Has This Been Tested?

Tested this by reproducing it and adding this line to our local npm package.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.

jlast added some commits Feb 7, 2019

@aweber1

aweber1 approved these changes Mar 5, 2019

@aweber1 aweber1 merged commit f7bc204 into Sitecore:dev Mar 5, 2019

1 check passed

Sitecore.jss Build #20190207.2 succeeded
Details
@aweber1

This comment has been minimized.

Copy link
Member

commented Mar 5, 2019

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.