Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] Add directive for general links that can be both internal and external #213

Merged
merged 3 commits into from Jul 16, 2019

Conversation

@jlast
Copy link
Contributor

commented Jul 15, 2019

Add angular directive for general links that can be both internal and external.
This allows Content Editors to not be limited to one type of predefined linkfield while maintaining angular routerlinks

Description

Add angular directive for general links that can be both internal and external.
This allows Content Editors to not be limited to one type of predefined linkfield while maintaining angular routerlinks

Motivation

Currently the implementation of a link is limited by developers. Either they choose *scLink which doesn't use angular routerlinks, or *scRouterLink which solely uses routerlinks. This directive decides whether the link has a protocol and is therefor an external link.

How Has This Been Tested?

Added unit tests and tested it on our application.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.

Jeroen van der Last added some commits Jul 15, 2019

@kamsar

kamsar approved these changes Jul 16, 2019

@kamsar kamsar merged commit 8380745 into Sitecore:dev Jul 16, 2019

1 check passed

Sitecore.jss Build #20190716.3 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.