Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] Allow lazy loaded components to show a loading state #223

Merged
merged 10 commits into from Aug 7, 2019

Conversation

@jlast
Copy link
Contributor

jlast commented Jul 25, 2019

Allow lazy loaded components to show a loading state

Description

Allow lazy loaded components to show a loading state.

Motivation

This solves #197

How Has This Been Tested?

  • Updated and added unit tests.
  • Implemented in our application.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
ds-sc and others added 9 commits Jul 5, 2019
Added a method for seeing http error message
Jeroen van der Last
@kamsar
kamsar approved these changes Jul 25, 2019
@sc-dawidrutkowski sc-dawidrutkowski merged commit 35588ce into Sitecore:dev Aug 7, 2019
1 check passed
1 check passed
Sitecore.jss Build #20190725.2 succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.