New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Remove-ItemLanguage - changed to general Add/Remove-ItemVersion - version management commands #532

Closed
michaellwest opened this Issue Dec 9, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@michaellwest
Member

michaellwest commented Dec 9, 2015

Edity by @AdamNaj

Commands renamed. Aliasses added for compatibility.
Tests showing it in operations in the Gist

@michaellwest michaellwest self-assigned this Dec 9, 2015

@michaellwest michaellwest added this to the 4.0 milestone Dec 9, 2015

@michaellwest

This comment has been minimized.

@AdamNaj

This comment has been minimized.

Member

AdamNaj commented Dec 9, 2015

I need to look at the implementation but I think we might want to rename the Add-ItemLanguage and Remove-ItemLanguage to as effectively those would do the same thing to a degree. Max Version pruning is really the thing to add.

@michaellwest

This comment has been minimized.

Member

michaellwest commented Dec 10, 2015

I would think that adding separate commands will help keep the command from becoming bloated or complicated.

@AdamNaj

This comment has been minimized.

Member

AdamNaj commented Dec 10, 2015

The thing is that other than trimming to max number they are pretty much doing the same :)

@AdamNaj AdamNaj changed the title from Commands to manage versions to Add/Remove-ItemLanguage - changed to general Add/Remove-ItemVersion - version management commands Jan 5, 2016

AdamNaj added a commit that referenced this issue Jan 6, 2016

AdamNaj added a commit that referenced this issue Jan 6, 2016

@AdamNaj AdamNaj assigned AdamNaj and unassigned michaellwest Jan 9, 2016

AdamNaj added a commit that referenced this issue Jan 11, 2016

@AdamNaj

This comment has been minimized.

Member

AdamNaj commented Jan 11, 2016

Implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment