New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Experience buttons Integration Point #546

Closed
michaellwest opened this Issue Dec 21, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@michaellwest
Member

michaellwest commented Dec 21, 2015

Add a new integration point for the getChromeData pipeline.

@michaellwest

This comment has been minimized.

Member

michaellwest commented Dec 21, 2015

Implemented. @AdamNaj please review.

@michaellwest michaellwest assigned AdamNaj and unassigned michaellwest Dec 21, 2015

@AdamNaj

This comment has been minimized.

Member

AdamNaj commented Dec 22, 2015

Looks interesting. Need some additional work. Personally I'd name it "Experience Buttons" as I thin that's how those are called from the user's point of view. Also a script for creating the integration point script library would be required.

AdamNaj added a commit that referenced this issue Dec 29, 2015

@AdamNaj AdamNaj changed the title from Add ChromeData Integration Point to Add Experience buttons Integration Point Jan 1, 2016

AdamNaj added a commit that referenced this issue Jan 2, 2016

AdamNaj added a commit that referenced this issue Jan 3, 2016

AdamNaj added a commit that referenced this issue Jan 4, 2016

@AdamNaj

This comment has been minimized.

Member

AdamNaj commented Jan 5, 2016

Ok, this item has now been re-implemented to work like the other integration points. Enabled conditionally with rules.

@AdamNaj AdamNaj closed this Jan 5, 2016

AdamNaj added a commit that referenced this issue Jan 5, 2016

@michaellwest

This comment has been minimized.

Member

michaellwest commented Jan 30, 2016

This will need to be moved to the Cognifide.PowerShell.Sitecore8 library.

WebEditScriptCommand.cs
PageEditorExperienceButtonScript.cs

@michaellwest michaellwest reopened this Jan 30, 2016

@AdamNaj

This comment has been minimized.

Member

AdamNaj commented Jan 30, 2016

Already done that yesterday, during the old SC version tests :)
Actually only the first class need to be version specific, as far as I could see.
Why do you think the second one needs to be moved?

@michaellwest

This comment has been minimized.

Member

michaellwest commented Jan 30, 2016

I could be wrong. The first gave me an error. Wasn't sure if the second one needed to move too. Just making sure.

@AdamNaj

This comment has been minimized.

Member

AdamNaj commented Jan 31, 2016

Fixed with commit 69b45e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment