New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security : Add MemberOf property for User and Role objects #842

Closed
michaellwest opened this Issue Feb 27, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@michaellwest
Member

michaellwest commented Feb 27, 2017

As can be seen here there is a need to return the membership for users and roles.

image

@michaellwest michaellwest self-assigned this Feb 27, 2017

@michaellwest michaellwest added this to the 4.4.2 milestone Feb 27, 2017

@michaellwest

This comment has been minimized.

Member

michaellwest commented Feb 27, 2017

Implemented.

@AdamNaj

This comment has been minimized.

Member

AdamNaj commented Feb 28, 2017

The User already contains property Roles that was added in the last release. Can you please align the implementation with the existing one? I would rather not have duplicated properties and breaking changes if we can avoid them.

michaellwest added a commit that referenced this issue Feb 28, 2017

#842 : Changed MemberOf to an alias property.
Also added a new property Roles to the User object.
@michaellwest

This comment has been minimized.

Member

michaellwest commented Feb 28, 2017

@AdamNaj I changed the MemberOf property to an Alias and added a Roles property to the Role object.

@AdamNaj

This comment has been minimized.

Member

AdamNaj commented Feb 28, 2017

Looks good now.

Seal of approval

@AdamNaj AdamNaj closed this Feb 28, 2017

@michaellwest

This comment has been minimized.

Member

michaellwest commented Feb 28, 2017

Good recommendation.

@AdamNaj AdamNaj added the improvement label Feb 28, 2017

@michaellwest michaellwest removed their assignment May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment