Bait selection added #21

DaGuT · 2021-10-02T13:32:38Z

Do not merge it yet, I have not tested it.

But with this PR you'll be able to select two new places (position of bait and position of equip button for bait confirmation).

After repairing it'll automatically select bait (so it has the same timer as repair!)

DaGuT · 2021-10-02T15:24:13Z

#16

DaGuT · 2021-10-02T15:35:57Z

feels like it works, I guess you can merge it now

Siterizer · 2021-10-03T08:28:08Z

@DaGuT sorry for late reeponse but you know, weekend etc. Before i merge this i would like to test IT myself, but you know The queues. I think i will test Ii tommorow.
Btw thanks for your help with contribution 🥰

DaGuT · 2021-10-03T13:35:55Z

sure, no problem :)

Enjoy the game. That's what it is meant for

JKamsker · 2021-10-04T23:58:12Z

Here, have some cookie for that @DaGuT 🍪

DaGuT · 2021-10-05T05:25:39Z

There is a bug. When bait is disabled, it still uses it. Gonna fix it this evening after I come home:)

UPD: Yeah, I forgot to add .get() when checking if bait is enabled :(((

DaGuT · 2021-10-05T21:31:23Z

fixed with DaGuT@8211b38

ivan-cavero · 2021-10-06T13:19:43Z

I have been testing it and it works very well, so you can get another person's opinion. Thank you both very much for your work :)

davidgao93 · 2021-10-07T01:01:14Z

Can confirm that this works for me as well, for some reason the original version would stop after a few hours and the camera would bug out but this one is fine.

tallglen · 2021-10-07T05:11:48Z

I have been testing it and it works very well, so you can get another person's opinion. Thank you both very much for your work :)

I'll do some testing tonight.

ivan-cavero · 2021-10-07T12:07:01Z

I have been testing it and it works very well, so you can get another person's opinion. Thank you both very much for your work :)

I'll do some testing tonight.

Does it work after the update?

tallglen · 2021-10-07T15:08:51Z

I have been testing it and it works very well, so you can get another person's opinion. Thank you both very much for your work :)

I'll do some testing tonight.

Does it work after the update?

Yup worked so another +1 from me

danmarzola · 2021-10-08T01:31:40Z

Working Fine

litlhogn · 2021-10-08T02:37:00Z

I have been been using this commit for 3 days now. I have had no issues with it functioning as written. Obviously, it would be nice if it could eventually determine which bait type to use, but it works fantastic.

BmanXD · 2021-10-08T13:15:16Z

How do you test this version? I'd like to give it a go

DaGuT · 2021-10-08T13:18:53Z

How do you test this version? I'd like to give it a go

https://github.com/Siterizer/new-world-fishing-bot#code-installation-guide

dvz95 · 2021-10-08T13:23:13Z

Sorry, how exactly do I try this code coz that link above was just to the original code’s readme

ivan-cavero · 2021-10-08T13:27:22Z

The other day I could use it perfect, and I used it 2 days, but after the patch when I try to use it I get in console "[INFO] Pause fishing" I have tried different things, throw the fishing rod and it works fine until I recognize the fish, but then I get again "[INFO] Pause fishing". Do you know what could it be? I haven't changed anything, and it was working fine before.

DaGuT · 2021-10-08T14:08:03Z

The other day I could use it perfect, and I used it 2 days, but after the patch when I try to use it I get in console "[INFO] Pause fishing" I have tried different things, throw the fishing rod and it works fine until I recognize the fish, but then I get again "[INFO] Pause fishing". Do you know what could it be? I haven't changed anything, and it was working fine before.

There is a high chance for:

You settings have changed after update
You weared something that has "pause" color in it.

So, make sure you have proper settings, reduce the box so that it does not include anything orange and red. You can also look at the ground to reduce the chance of anything being in the "spot zone".

So it's not about update, it's about you doing it with different conditions

danmarzola · 2021-10-08T14:18:55Z

Sorry, how exactly do I try this code coz that link above was just to the original code’s readme

Just download from @DaGuT fork https://github.com/DaGuT/new-world-fishing-bot

danmarzola · 2021-10-08T14:21:34Z

The other day I could use it perfect, and I used it 2 days, but after the patch when I try to use it I get in console "[INFO] Pause fishing" I have tried different things, throw the fishing rod and it works fine until I recognize the fish, but then I get again "[INFO] Pause fishing". Do you know what could it be? I haven't changed anything, and it was working fine before.

There is a high chance for:

You settings have changed after update

You weared something that has "pause" color in it.

So, make sure you have proper settings, reduce the box so that it does not include anything orange and red. You can also look at the ground to reduce the chance of anything being in the "spot zone".

So it's not about update, it's about you doing it with different conditions

I noticed that "torchs" in cities like Mourningdale mess with color detection, just avoid anything orange~yellow in your fishing rectangle

dvz95 · 2021-10-08T14:21:36Z

There is no exe to run

…

________________________________ From: danmarzola ***@***.***> Sent: Saturday, October 9, 2021 1:19:07 AM To: Siterizer/new-world-fishing-bot ***@***.***> Cc: dvz95 ***@***.***>; Comment ***@***.***> Subject: Re: [Siterizer/new-world-fishing-bot] Bait selection added (#21) Sorry, how exactly do I try this code coz that link above was just to the original code’s readme Just download from @DaGuT<https://github.com/DaGuT> fork https://github.com/DaGuT/new-world-fishing-bot — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#21 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQ7RLABG3FB6A3PZ6YPXXVDUF34VXANCNFSM5FGNGQHQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

dvz95 · 2021-10-08T14:21:52Z

Sorry, how exactly do I try this code coz that link above was just to the original code’s readme

Just download from @DaGuT fork https://github.com/DaGuT/new-world-fishing-bot

There is no exe to run.

danmarzola · 2021-10-08T14:25:53Z

There is no exe to run
…
________________________________ From: danmarzola @.> Sent: Saturday, October 9, 2021 1:19:07 AM To: Siterizer/new-world-fishing-bot @.> Cc: dvz95 @.>; Comment @.> Subject: Re: [Siterizer/new-world-fishing-bot] Bait selection added (#21) Sorry, how exactly do I try this code coz that link above was just to the original code’s readme Just download from @DaGuT https://github.com/DaGuT fork https://github.com/DaGuT/new-world-fishing-bot — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#21 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ7RLABG3FB6A3PZ6YPXXVDUF34VXANCNFSM5FGNGQHQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You need create it

Install Python, open console go to git folder and get path, write down something like "cd C:\path\new-world-fishing-bot"
follow instruction in cmd:

Create python virtual enviroment python -m venv path\new-world-fishing-bot
Enter virtual enviroment Scripts\activate just type "cd C:\path\new-world-fishing-bot\Scripts" then activate in console
Install following modules:
pip install pyyaml
pip install pywin32
pip install numpy
pip install opencv-python
pip install Pillow

then you can:

If you would like to create your own .exe file:
Install: pip install pyinstaller
Run following command: pyinstaller --add-data resources;resources bot.py
Your exe file should generate in dist\bot\bot.exe

You should run without generating .exe first to get your settings saved.
Just type "cd C:\path\new-world-fishing-bot" then "python bot.py" to run and to save your settings by just exitting in GUI

Mpaulo · 2021-10-08T16:32:09Z

sorry for my little understanding, but does using the bait make fishing a lot better? in the amount of rare and legendary fish? I was seeing the best baits and there is not much information in them and I would like to test this version

tallglen · 2021-10-08T16:46:45Z

sorry for my little understanding, but does using the bait make fishing a lot better? in the amount of rare and legendary fish? I was seeing the best baits and there is not much information in them and I would like to test this version

It's all based on % chance. Adding bait adds some % chance. So it's better but it's not going to make catching things guaranteed.

tallglen · 2021-10-08T18:25:26Z

The other day I could use it perfect, and I used it 2 days, but after the patch when I try to use it I get in console "[INFO] Pause fishing" I have tried different things, throw the fishing rod and it works fine until I recognize the fish, but then I get again "[INFO] Pause fishing". Do you know what could it be? I haven't changed anything, and it was working fine before.

There is a high chance for:

You settings have changed after update

You weared something that has "pause" color in it.

So, make sure you have proper settings, reduce the box so that it does not include anything orange and red. You can also look at the ground to reduce the chance of anything being in the "spot zone".

So it's not about update, it's about you doing it with different conditions

I had a similar issue; starting using the bot with another character that I'm doing a different build on and the appearance is not exactly the same as my other character and the bot isn't working as well. Going to try later without any clothes equipped and point it at the ground to see if it helps.

BmanXD · 2021-10-09T02:05:21Z

I cant install 3 modules
pip install pywin32
pip install numpy
pip install opencv-python

got a ton of errors

tallglen · 2021-10-09T02:32:38Z

I cant install 3 modules pip install pywin32 pip install numpy pip install opencv-python

got a ton of errors

Did you use a virtualenv?

BmanXD · 2021-10-09T02:46:52Z

Yes, activated then typed in what was provided for all modules. 2 worked fine and the other 3 didnt

JKamsker · 2021-10-09T04:53:44Z

With the bait the bot seems to have a problem with the secret fishermans spot when hitting a good spot. The fishes are cought faster than the bot expects.

DaGuT · 2021-10-09T05:05:10Z

With the bait the bot seems to have a problem with the secret fishermans spot when hitting a good spot. The fishes are cought faster than the bot expects.

That cant be. Reduce the greenbox size so that your pc can handle cv

New functions are not computantional heavy at all, so they can not be a problem of that.

Moreover, they are checked and called only after repair is used, so there is not even a single cpu operation that is different at any other moment

Siterizer · 2021-10-09T10:48:19Z

@DaGuT Trully awesome work, i love you <3 works in the first try.
Changed gui a little bit (sorry but i am perfectionist xd) b36c2cc

JKamsker · 2021-10-09T11:10:02Z

@DaGuT I think you got me wrong.
The time the fish appears is far inside the post casting sleep.

D-main · 2021-10-09T22:46:17Z

Works great

DaGuT added 5 commits October 2, 2021 16:22

added 'select bait' functionality

21e4ca1

returned back fishing bot name

59959e3

fixed typo

ce6dd31

added back forgotten tabulation

247f7df

centered start fishing button

2c569d2

DaGuT mentioned this pull request Oct 2, 2021

Feature requests. #16

Closed

Update enable.py

3f21e2a

DaGuT mentioned this pull request Oct 3, 2021

Bait ? #26

Closed

hotfix for repair beign disabled when bait is disabled

2c1424c

fixed bait working even if disabled

8211b38

Siterizer merged commit 7b1c89e into Siterizer:main Oct 9, 2021

Siterizer mentioned this pull request Oct 9, 2021

Fish bot, trouble with bait #68

Closed

Bait selection added #21

Bait selection added #21

Conversation

DaGuT commented Oct 2, 2021

DaGuT commented Oct 2, 2021

DaGuT commented Oct 2, 2021

Siterizer commented Oct 3, 2021

DaGuT commented Oct 3, 2021

JKamsker commented Oct 4, 2021

DaGuT commented Oct 5, 2021 • edited Loading

DaGuT commented Oct 5, 2021

ivan-cavero commented Oct 6, 2021

davidgao93 commented Oct 7, 2021

tallglen commented Oct 7, 2021

ivan-cavero commented Oct 7, 2021

tallglen commented Oct 7, 2021

danmarzola commented Oct 8, 2021

litlhogn commented Oct 8, 2021

BmanXD commented Oct 8, 2021

DaGuT commented Oct 8, 2021 • edited Loading

dvz95 commented Oct 8, 2021

ivan-cavero commented Oct 8, 2021

DaGuT commented Oct 8, 2021 • edited Loading

danmarzola commented Oct 8, 2021

danmarzola commented Oct 8, 2021

dvz95 commented Oct 8, 2021 via email

dvz95 commented Oct 8, 2021

danmarzola commented Oct 8, 2021 • edited Loading

Mpaulo commented Oct 8, 2021

tallglen commented Oct 8, 2021

tallglen commented Oct 8, 2021

BmanXD commented Oct 9, 2021

tallglen commented Oct 9, 2021

BmanXD commented Oct 9, 2021

JKamsker commented Oct 9, 2021

DaGuT commented Oct 9, 2021 • edited Loading

Siterizer commented Oct 9, 2021

JKamsker commented Oct 9, 2021

D-main commented Oct 9, 2021

DaGuT commented Oct 5, 2021 •

edited

Loading

DaGuT commented Oct 8, 2021 •

edited

Loading

DaGuT commented Oct 8, 2021 •

edited

Loading

danmarzola commented Oct 8, 2021 •

edited

Loading

DaGuT commented Oct 9, 2021 •

edited

Loading