Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Blob Storage Providers #49

Merged
merged 24 commits into from
May 25, 2019
Merged

Azure Blob Storage Providers #49

merged 24 commits into from
May 25, 2019

Conversation

JimBobSquarePants
Copy link
Member

@JimBobSquarePants JimBobSquarePants commented Dec 29, 2018 •
edited
Loading

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #25

  • Adds a new library SixLabors.ImageSharp.Web.Providers.Azure that allows the retrieval of images from Azure Blob Storage.
  • Simplifies setup configuration allowing replacement of individual parts.

@JimBobSquarePants JimBobSquarePants changed the title WIP Azure Blob Storage Providers Azure Blob Storage Providers May 18, 2019
@JimBobSquarePants JimBobSquarePants mentioned this pull request May 18, 2019
Closed
@JimBobSquarePants
Copy link
Member Author

Going ahead with the merge. I'm very happy with how this has worked out.

@JimBobSquarePants JimBobSquarePants merged commit 75fd113 into master May 25, 2019
@JimBobSquarePants JimBobSquarePants deleted the js/azure-blob branch May 25, 2019 10:41
@tmarman tmarman mentioned this pull request Aug 27, 2019
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroymann kroymann kroymann left review comments

@tocsoft tocsoft Awaiting requested review from tocsoft

@antonfirsov antonfirsov Awaiting requested review from antonfirsov

@dlemstra dlemstra Awaiting requested review from dlemstra

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Created a basic Azure Blob ImageResolver
2 participants
@JimBobSquarePants @kroymann