Skip to content

Commit

Permalink
add netcoreapp2.1 target and change README.md
Browse files Browse the repository at this point in the history
  • Loading branch information
antonfirsov committed May 21, 2018
1 parent bf55d59 commit 50cda5d
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 12 deletions.
14 changes: 9 additions & 5 deletions README.md
Expand Up @@ -115,17 +115,21 @@ For more examples check out:

### Manual build

If you prefer, you can compile ImageSharp yourself (please do and help!), you'll need:
If you prefer, you can compile ImageSharp yourself (please do and help!)

- [Visual Studio 2017 (or above)](https://www.visualstudio.com/en-us/news/releasenotes/vs2017-relnotes)
- The [.NET Core SDK Installer](https://www.microsoft.com/net/core#windows) - Non VSCode link.
- Using [Visual Studio 2017 Preview](https://docs.microsoft.com/en-us/visualstudio/releasenotes/vs2017-preview-relnotes)
- Make sure you have the latest version installed
- Make sure you have [the newest 2.1 RC1 SDK installed](https://www.microsoft.com/net/core#windows)

Alternatively on Linux you can use:
- Using [Visual Studio 2017](https://www.visualstudio.com/en-us/news/releasenotes/vs2017-relnotes)
- If you are unable and/or don't want to build ImageSharp.Tests against 2.1 RC, remove the `netcoreapp2.1` target [from TargetFrameworks](https://github.com/SixLabors/ImageSharp/blob/master/tests/ImageSharp.Tests/ImageSharp.Tests.csproj#L3) locally

Alternatively, you can work from command line and/or with a lightweight editor on **both Linux/Unix and Windows**:

- [Visual Studio Code](https://code.visualstudio.com/) with [C# Extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode.csharp)
- [.Net Core](https://www.microsoft.com/net/core#linuxubuntu)

To clone it locally click the "Clone in Windows" button above or run the following git commands.
To clone ImageSharp locally click the "Clone in Windows" button above or run the following git commands.

```bash
git clone https://github.com/SixLabors/ImageSharp
Expand Down
25 changes: 19 additions & 6 deletions appveyor.yml
Expand Up @@ -6,16 +6,29 @@ skip_branch_with_pr: true

environment:
matrix:
### TODO: Enable the netcoreapp2.1 target when RC2 has been released!

#- target_framework: netcoreapp2.1
# is_32bit: False

#- target_framework: netcoreapp2.1
# is_32bit: True

- target_framework: netcoreapp2.0
is_32bit: False

- target_framework: net471
is_32bit: False

- target_framework: net471
is_32bit: True

- target_framework: net462
is_32bit: False

- target_framework: net462
is_32bit: True
- target_framework: net471
is_32bit: False
- target_framework: netcoreapp2.0
is_32bit: False

#- target_framework: netcoreapp2.0 # As far as I understand, 32 bit test execution is not supported by "dotnet xunit"
# is_32bit: True
#- target_framework: mono
Expand All @@ -39,7 +52,7 @@ install:
before_build:
- git submodule -q update --init
- cmd: dotnet --version
- cmd: dotnet --info

build_script:
- cmd: build.cmd
Expand All @@ -60,4 +73,4 @@ deploy:
secure: V/lEHP0UeMWIpWd0fiNlY2IgbCnJKQlGdRksECdJbOBdaE20Fl0RNL7WyqHe02o4
artifact: /.*\.nupkg/
on:
branch: master
branch: master
2 changes: 1 addition & 1 deletion tests/ImageSharp.Tests/ImageSharp.Tests.csproj
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>net471;netcoreapp2.0;net462;net47</TargetFrameworks>
<TargetFrameworks>netcoreapp2.1;netcoreapp2.0;net471;net47;net462</TargetFrameworks>
<AllowUnsafeBlocks>True</AllowUnsafeBlocks>
<LangVersion>7.2</LangVersion>
<DebugType Condition="$(codecov) != ''">full</DebugType>
Expand Down

0 comments on commit 50cda5d

Please sign in to comment.