Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MathF, Constants, and ComparableExtensions public #246

Closed
Inumedia opened this Issue Jun 11, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@Inumedia
Copy link

Inumedia commented Jun 11, 2017

Description

MathF, Constants, and ComparableExtensions should be made public so as to easily add other PixelFormats.

  • ImageSharp version: 1.0.0-alpha9-00139
  • Environment (Operating system, version and so on): All
@antonfirsov

This comment has been minimized.

Copy link
Member

antonfirsov commented Jun 11, 2017

@Inumedia we want to keep our public API as narrow as possible keeping our ability to change these internal utilities as our design evolves, so I don't think these API-s should be public.

A possible change for MathF: A standard MathF class is coming, we should adapt it in the future.

These utilities are really thin, so you can easily include them into your project. If you are implementing a new pixel type you might also PR it into ImageSharp ;)

@JimBobSquarePants

This comment has been minimized.

Copy link
Member

JimBobSquarePants commented Jun 12, 2017

Our MathF class only actually exists due to the linked CoreFX issue. I wanted to be prepared to switch out easily when it's available.

Clamp is also via System.Math so we don't want to expose our extensions yet either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.