Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addional gif test cases #1191

Merged
merged 4 commits into from Apr 28, 2020
Merged

Addional gif test cases #1191

merged 4 commits into from Apr 28, 2020

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

This PR adds additional gif tests for some edge cases. Test images are from pygif.
I have added a check if the image descriptor height or width is zero and throw a appropriate exception.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're a beast with Image Formats! Love it!

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #1191 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1191   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files         692      692           
  Lines       29986    29988    +2     
  Branches     3388     3389    +1     
=======================================
+ Hits        24752    24755    +3     
+ Misses       4537     4536    -1     
  Partials      697      697           
Flag Coverage 螖
#unittests 82.54% <100.00%> (+<0.01%) 猬嗭笍
Impacted Files Coverage 螖
src/ImageSharp/Formats/Gif/GifDecoderCore.cs 83.89% <100.00%> (+0.13%) 猬嗭笍
src/ImageSharp/Formats/Gif/GifThrowHelper.cs 100.00% <0.00%> (+50.00%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 39dd158...5854921. Read the comment docs.

@brianpopow brianpopow merged commit e790f94 into master Apr 28, 2020
@brianpopow brianpopow deleted the gifTests branch April 28, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants