Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Gradient Brushes #542
Implementing Gradient Brushes:
Color Repetition Modes
What I'd like to add in future PRs:
Apr 19, 2018
left a comment
the reason you are getting a black screen is because of a bug in the base
@@ Coverage Diff @@ ## master #542 +/- ## ========================================== - Coverage 87.67% 87.26% -0.41% ========================================== Files 838 840 +2 Lines 34684 35107 +423 Branches 2533 2553 +20 ========================================== + Hits 30410 30637 +227 - Misses 3524 3719 +195 - Partials 750 751 +1
Where are we with this PR? I'm seeing lots of reference images missing.
@JimBobSquarePants you're right. To lower the burden on you all I wanted to self-review my test cases once again before asking to add the reference images.
I'm not satisfied with the state of the documentation, but I fear I'm blind to what's needed for someone not familiar with the API.
Reference Output of the test cases has changed slightly: Not the content of the individual images, but the images itself due to changed file names and slightly different test cases. These would have to be copied to the external repository again.