New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #576, using explicit struct layout for bgr24 and rgb24 #591

Merged
merged 6 commits into from May 24, 2018

Conversation

Projects
None yet
3 participants
@brianpopow
Copy link
Contributor

brianpopow commented May 23, 2018

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 馃懏.
  • I have provided test coverage for my change (where applicable)

Description

This PR addresses to fix the issue that ImageCloneTests.CloneAs_ToBgr24() was failing sporadically.
rgb24 struct was also changed, because it may also be affected by this issue.

@brianpopow brianpopow referenced this pull request May 23, 2018

Closed

ImageCloneTests.CloneAs_ToBgr24() failing sporadically #576

4 of 4 tasks complete
@codecov

This comment has been minimized.

Copy link

codecov bot commented May 23, 2018

Codecov Report

Merging #591 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
+ Coverage   88.73%   88.78%   +0.04%     
==========================================
  Files         854      854              
  Lines       36172    36172              
  Branches     2620     2620              
==========================================
+ Hits        32099    32114      +15     
+ Misses       3290     3275      -15     
  Partials      783      783
Impacted Files Coverage 螖
src/ImageSharp/PixelFormats/Bgr24.cs 80% <酶> (+4%) 猬嗭笍
src/ImageSharp/PixelFormats/Rgb24.cs 77.55% <酶> (酶) 猬嗭笍
tests/ImageSharp.Tests/Image/ImageCloneTests.cs 100% <酶> (+24.07%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 74495d6...2956d42. Read the comment docs.

JimBobSquarePants and others added some commits May 23, 2018

@antonfirsov
Copy link
Member

antonfirsov left a comment

Unksipped CloneAs_ToBgr24. We should merge this, if the build succeeds,

@JimBobSquarePants JimBobSquarePants merged commit 0fd4097 into SixLabors:master May 24, 2018

5 checks passed

codecov/patch Coverage not affected when comparing 74495d6...2956d42
Details
codecov/project 88.78% (+0.04%) compared to 74495d6
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment