-
-
Notifications
You must be signed in to change notification settings - Fork 101
231. Power of Two #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
231. Power of Two #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a new Solution method that efficiently determines if an integer is a power of two using a bitwise trick. Class diagram for the new Solution class with isPowerOfTwo methodclassDiagram
class Solution {
+bool isPowerOfTwo(int n)
}
Flow diagram for isPowerOfTwo logicflowchart TD
A["Input: n"] --> B["n <= 0?"]
B -- Yes --> C["Return false"]
B -- No --> D["Compute n & (n-1)"]
D --> E["Result == 0?"]
E -- Yes --> F["Return true"]
E -- No --> G["Return false"]
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closed
🎉 Congrats on getting your PR merged in, @Subhosjx! 🙌🏼Thanks for your contribution every effort helps improve the project. Looking forward to seeing more from you! 🥳✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title Format: Problem no.Problem name.cpp
Approach
A number
nis a power of two if:n > 0Trick: For powers of two,
n & (n - 1) == 0.Example:
n & (n-1) = 0000✅n & (n-1) = 0100❌Intuition
Binary representation of powers of two looks like: 1 (0001), 2 (0010), 4 (0100), 8 (1000), 16 (10000) ...
Each has exactly one set bit.
Therefore, checking
(n > 0) && (n & (n-1)) == 0efficiently verifies this.Code Solution (C++)
Related Issues #109
By submitting this PR, I confirm that:
Summary by Sourcery
New Features: