From ec717bcef5acb0b075eec7cb4d802fa5df0ee3ef Mon Sep 17 00:00:00 2001
From: Ross Keenan <rossk29@gmail.com>
Date: Tue, 3 Aug 2021 10:48:58 +0200
Subject: [PATCH] fix(getFieldValues): :bug: Better falsey checking on
 rawValues

---
 .vscode/settings.json  |  3 ++-
 src/sharedFunctions.ts | 36 ++++++++++++++++++++----------------
 2 files changed, 22 insertions(+), 17 deletions(-)

diff --git a/.vscode/settings.json b/.vscode/settings.json
index 6d2773f0..ee027d28 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -5,6 +5,7 @@
         "Juggl",
         "List/Matrix View",
         "Stats View",
-        "Vis View"
+        "Vis View",
+        "getFieldValues"
     ]
 }
\ No newline at end of file
diff --git a/src/sharedFunctions.ts b/src/sharedFunctions.ts
index 9b2c3243..206a8b7c 100644
--- a/src/sharedFunctions.ts
+++ b/src/sharedFunctions.ts
@@ -1,7 +1,13 @@
 import type { Graph } from "graphlib";
 import * as graphlib from "graphlib";
 import { parseTypedLink } from "juggl-api";
-import type { App, FrontMatterCache, TFile, WorkspaceLeaf } from "obsidian";
+import type {
+  App,
+  FrontMatterCache,
+  Pos,
+  TFile,
+  WorkspaceLeaf,
+} from "obsidian";
 import { dropHeaderOrAlias, splitLinksRegex } from "src/constants";
 import type {
   BreadcrumbsSettings,
@@ -173,27 +179,25 @@ export function getFieldValues(
   settings: BreadcrumbsSettings
 ) {
   // Narrow down the possible types
-  const rawValues: (string | dvLink | undefined)[] =
-    [frontmatterCache?.[field]].flat(5) ?? null;
+  const rawValues: (string | dvLink | Pos | undefined)[] = [
+    frontmatterCache?.[field],
+  ].flat(5);
 
   superDebug(settings, `${field} of: ${frontmatterCache.file.path}`);
   superDebug(settings, { rawValues });
 
-  // If there are any values for that field, and they're not undefined
-  if (rawValues.length && rawValues[0]) {
-    if (typeof rawValues[0] === "string") {
-      return splitAndDrop(rawValues[0]).map((str: string) =>
-        str.split("/").last()
-      );
-    } else {
-      // Assuming it's a dvLink
-      return (rawValues as dvLink[]).map((link: dvLink) =>
-        link.path.split("/").last()
+  const values: string[] = [];
+  rawValues.forEach((rawItem) => {
+    if (!rawItem) return;
+    if (typeof rawItem === "string") {
+      values.push(
+        ...splitAndDrop(rawItem).map((str: string) => str.split("/").last())
       );
+    } else if (rawItem.path) {
+      values.push((rawItem as dvLink).path.split("/").last());
     }
-  } else {
-    return [];
-  }
+  });
+  return values;
 }
 
 export const splitAndTrim = (fields: string): string[] =>