Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes TestUp tests for SketchUp 2013 #48

Merged
merged 1 commit into from Aug 9, 2013

Conversation

Projects
None yet
2 participants
Contributor

bjanzen commented Jun 14, 2013

Removing bugs_fixed/TC_2119710.rb and functional_tests/TC_Picking.rb
because they were using files in lib/ that we never shipped, and will
break in the next version of SketchUp. A complete refactor is
necessary. Deletion will cause less confusion IMHO.

functional_tests/TC_BreakEdges2D.rb had no localization and was
barfing, so I removed the $exStrings.GetString

functional_tests/TC_importers_sanity.rb broke because of Mac
Preferences changes, and was overly complicated. Simplified greatly by
updating dictionary plist items using -dict-add. Also, a new 2013 bug
requiring a placement of a 3D before it's edges, faces etc… were added
to the model statistics, required similar treatment to skps.

functional_tests/TC_install_from_rbz.rb now uses su_webtextures.rb,
because Examples are no longer installed by default.

ruby_classes/TC_Image.rb needed a little refactor love, and DC's have
moved from Tools to Plugins.

ruby_classes/TC_SketchupExtension.rb requires Examples to be installed,
and now checks for it and raises an exception if with instructions on
how to get it installed if it's not there.

@bjanzen bjanzen Fixes TestUp tests for SketchUp 2013
Removing bugs_fixed/TC_2119710.rb and functional_tests/TC_Picking.rb
because they were using files in lib/ that we never shipped, and will
break in the next version of SketchUp.  A complete refactor is
necessary.  Deletion will cause less confusion IMHO.

functional_tests/TC_BreakEdges2D.rb had no localization and was
barfing, so I removed the $exStrings.GetString

functional_tests/TC_importers_sanity.rb broke because of Mac
Preferences changes, and was overly complicated.  Simplified greatly by
updating dictionary plist items using -dict-add.  Also, a new 2013 bug
requiring a placement of a 3D before it's edges, faces etc… were added
to the model statistics, required similar treatment to skps.

functional_tests/TC_install_from_rbz.rb now uses su_webtextures.rb,
because Examples are no longer installed by default.

ruby_classes/TC_Image.rb needed a little refactor love, and DC's have
moved from Tools to Plugins.

ruby_classes/TC_SketchupExtension.rb requires Examples to be installed,
and now checks for it and raises an exception if with instructions on
how to get it installed if it's not there.
792199f
Owner

thomthom commented Jun 15, 2013

I never got around to try out the test unit suite. So I don't feel I have much input to give on this. I can merge it after people chime in with their thoughts.

Owner

thomthom commented Aug 2, 2013

Should I just merge this?

@thomthom thomthom added a commit that referenced this pull request Aug 9, 2013

@thomthom thomthom Merge pull request #48 from bjanzen/TestUp-bugfix-2013
Fixes TestUp tests for SketchUp 2013
291603c

@thomthom thomthom merged commit 291603c into SketchUp:master Aug 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment