Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broadcast and message effect with 'or' list send all messages #4543

Closed
1 task done
3meraldK opened this issue Jan 29, 2022 · 2 comments
Closed
1 task done

broadcast and message effect with 'or' list send all messages #4543

3meraldK opened this issue Jan 29, 2022 · 2 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@3meraldK
Copy link
Contributor

3meraldK commented Jan 29, 2022

Skript/Server Version

[08:44:25 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[08:44:25 INFO]: [Skript] Skript's documentation can be found here: https://skriptlang.github.io/Skript
[08:44:25 INFO]: [Skript] Server Version: git-Airplane-"74774a0" (MC: 1.17.1)
[08:44:25 INFO]: [Skript] Skript Version: 2.6.1
[08:44:25 INFO]: [Skript] Installed Skript Addons:
[08:44:25 INFO]: [Skript] - skript-reflect v2.2.3 (https://github.com/TPGamesNL/skript-reflect)
[08:44:25 INFO]: [Skript] Installed dependencies:
[08:44:25 INFO]: [Skript] - Vault v1.7.3-b131

Bug Description

Given the example code
every 10 seconds: broadcast "text", "anothertext", "text2" or "bruh", Skript ignores the last or and broadcasts all messages at once.

Expected Behavior

Skript selects a random element out of the list.

Steps to Reproduce

  1. Reload skript with passed example and wait some time

Errors or Screenshots

No response

Other

It worked fine before 2.6.1.

Agreement

  • I have read the guidelines above and confirm I am following them with this report.
@NotSoDelayed
Copy link
Contributor

NotSoDelayed commented Jan 29, 2022

Can reproduce in Minecraft 1.16.5, Skript 2.6.1.

Alternatively, you can create a list of text, and use the random %object% .... expression:

broadcast random text of "test1", "test2" and "test3"

@TPGamesNL TPGamesNL changed the title Logical operators broken in 2.6.1 broadcast and message effect with 'or' list send all messages Jan 29, 2022
@TPGamesNL TPGamesNL added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Jan 29, 2022
@TPGamesNL
Copy link
Member

Also reproduceable with message effect. Behaviour changed in 2.6.1 #4197, but that PR made it so EffBroadcast was more like EffMessage, which also had the bug so it just carried the bug over.

@TPGamesNL TPGamesNL self-assigned this Jan 29, 2022
@TPGamesNL TPGamesNL added the PR available Issues which have a yet-to-be merged PR resolving it label Jan 29, 2022
@TPGamesNL TPGamesNL added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

No branches or pull requests

4 participants