Skip to content

Dungeon Secrets #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Sep 1, 2023
Merged

Dungeon Secrets #246

merged 38 commits into from
Sep 1, 2023

Conversation

kevinthegreat1
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 commented Aug 16, 2023 •
edited
Loading

Adds dungeon secrets waypoints.
This is currently usable but needs more testing, which is why I'm opening a pr now.

New changes

  • Fixed windows crash.
  • Fixed dungeon start detection (the player no longer needs to stay in the entrance room for a few seconds after dungeon start).
  • Added ability to disable certain types of waypoints.
  • Added ability to mark secrets as found or missing.
  • Fixed getMapEntrancePosAndRoomSize crash.
  • Turns off a lever waypoint when the lever is interacted with.
  • Resets on a new connection/world.
  • Double check 10 blocks after matching a room to make sure that the room is correct.

Known issues

  • There may be a small chance of rooms not getting detected.

Improvements

  • The ability to add custom waypoints.

@kevinthegreat1 kevinthegreat1 marked this pull request as draft August 17, 2023 03:33
@kevinthegreat1
Copy link
Collaborator Author

Meant to open as draft.

AzureAaron
AzureAaron requested changes Aug 18, 2023
View reviewed changes
@kevinthegreat1 kevinthegreat1 force-pushed the dungeon-secrets branch 5 times, most recently from 71b3265 to eaa19c7 Compare August 24, 2023 14:34
kevinthegreat1 and others added 22 commits August 30, 2023 22:49
@kevinthegreat1
Add Dungeon Secrets loading
369c6a9
@kevinthegreat1
Add Dungeon Secret Waypoint options
2a13974
@kevinthegreat1
Add entrance pos and room width parsing
d54ee77
@kevinthegreat1
Add DungeonRoomsDFU
2b185ea
@kevinthegreat1
Add rooms data updating
a5998f0
@kevinthegreat1
Add rooms data saving and update reading to nio
b81cd12
@kevinthegreat1
Add support for loading in jar
b77bb45
@kevinthegreat1
Remove json loading in DungeonRoomsDFU
611e771
@kevinthegreat1
Update ram usage data
dde565c
@kevinthegreat1
Add room position utils and physical room position parsing
5861621
@kevinthegreat1
Implement room
ad5dac4
@kevinthegreat1
Add room type and segments detection
d531919
@kevinthegreat1
Add room matching
2452ce3
@kevinthegreat1
Refactor room matching
1f40dff
@kevinthegreat1
Add secrets rendering
fd4462b
@kevinthegreat1
Fix secrets rendering
dc6efd3
@kevinthegreat1
Add secrets resetting
7257ed1
@kevinthegreat1
Add needs scanning check and refactor SecretWaypoint
3d1bf45
@kevinthegreat1
Refactor Room
96aa598
@AzureAaron @kevinthegreat1
Add text rendering method
43e8c33
@kevinthegreat1
Add SecretWaypoint text rendering
3c99924
@kevinthegreat1
Add secret found detection
3eb57e6
@kevinthegreat1 kevinthegreat1 marked this pull request as ready for review August 31, 2023 02:52
LifeIsAParadox
LifeIsAParadox approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@LifeIsAParadox LifeIsAParadox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kevinthegreat1 kevinthegreat1 merged commit 1370097 into SkyblockerMod:master Sep 1, 2023
@kevinthegreat1 kevinthegreat1 deleted the dungeon-secrets branch September 1, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LifeIsAParadox LifeIsAParadox LifeIsAParadox approved these changes

@AzureAaron AzureAaron AzureAaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinthegreat1 @LifeIsAParadox @AzureAaron