Dungeon bat #281
Merged
Dungeon bat #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureAaron
requested changes
Sep 8, 2023
| super(entityType, world); | ||
| } | ||
|
|
||
| @Unique |
There was a problem hiding this comment.
I would remove this because you’re overriding that method in the class, so unique won’t change anything here for compatibility (it gets ignored).
If your aim is compatibility, inject into the superclass method with an instanceof check but I don’t think another mod would do much regarding bat deaths.
kevinthegreat1
commented
Sep 8, 2023
AzureAaron
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detects when a bat is killed in a dungeon.
Fixes #279
Also adds bats to the list of glowing mobs.
Starred Mob Glow is now on by default.
Tested.