Skip to content

change lbin to hysky.de api #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2023
Merged

change lbin to hysky.de api #286

merged 2 commits into from
Sep 10, 2023

Conversation

LifeIsAParadox
Copy link
Member

Switched to the hysky.de API, also

  • Resolved issue Use Bazaar instead of AH in the tooltip #90
  • Optimization and cleanup
  • Implemented switch case logic instead of multiple if-else statements
  • Added early exit for cases where only the internal ID is required (e.g., NPC price)

AzureAaron
AzureAaron previously approved these changes Sep 9, 2023
View reviewed changes
@LifeIsAParadox
use lvl1 pet price only
60d8299 
change to level 1 pet price only
@LifeIsAParadox LifeIsAParadox linked an issue Sep 9, 2023 that may be closed by this pull request
Use Bazaar instead of AH in the tooltip #90
Closed
@AzureAaron AzureAaron merged commit 447a435 into SkyblockerMod:master Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureAaron AzureAaron AzureAaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Bazaar instead of AH in the tooltip
2 participants
@LifeIsAParadox @AzureAaron