Personal Compactor/Deletor preview #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update integrates a tooltip display for personal compactor items in the Skyblocker mod. The tooltip shows the contents of the personal compactor when hovered over. This is useful for players to quickly check the contents of their compactor without needing to open it. The commit includes creating a new Java file 'CompactorPreviewTooltipComponent.java' for the compactor tooltip component, adding new inject method 'skyblocker$addTooltipComponent' in 'HandledScreenMixin.java' executed when drawing mouseover tooltip, adding 'DrawContextInvoker.java' for invoking the 'drawTooltip' method in the 'DrawContext' class, and adding 'getItemStack' method in the 'ItemRegistry.java'.
Made it so it doesn't render the slots if no items (mainly for AH)
kevinthegreat1
requested changes
Sep 14, 2023
src/main/java/me/xmrvizzy/skyblocker/mixin/HandledScreenMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/mixin/HandledScreenMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/mixin/HandledScreenMixin.java
Outdated
Show resolved
Hide resolved
Split the logic for CompactorDeletorPreview to reduce the complexity within the HandledScreenMixin.java file. This change helps to make the code simpler and easier to maintain.
Refactored code by moving the BackpackPreview class to a new 'item' sub-package.
|
Made the changes you asked for. |
kevinthegreat1
approved these changes
Sep 15, 2023
AzureAaron
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the name implies, this adds a nice little preview of the contents of a Personal Compactor/Deletor when hovering it. Pretty cool right?
Images
If there are no items, only the slot count is showed (mainly used for AH):To make this go brrrr, i made a new class, mixin and an invoker.