Add hidden relic helper #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureAaron
requested changes
Sep 16, 2023
src/main/java/me/xmrvizzy/skyblocker/config/SkyblockerConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/skyblock/spidersden/Relics.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/skyblock/spidersden/Relics.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/skyblock/spidersden/Relics.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/skyblock/spidersden/Relics.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/skyblock/spidersden/Relics.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks for your contribution. However, I'm not quite convinced by some of your changes. There is not much point in doing trivial renames, rearranging methods, and moving sections of methods. Extracting methods and narrowing visibility are fine. Also, amount is grammatically incorrect.
kevinthegreat1
approved these changes
Sep 18, 2023
AzureAaron
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an highlighter for the hidden relic in the Spider's Den, which works very similar to the Fairy Soul helper.
The locations for the relics are taken from the Hypixel Skyblock Fandom Wiki
While working this feature I also cleanup some code of the fairy soul highlighter.
To help differentiate relics from fairy souls, relics are highlighted in yellow and brown (when found).
Config:
