New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YACL Config #328
YACL Config #328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look at the code. Didn't confirm the config screens, categories, and translations.
src/main/java/me/xmrvizzy/skyblocker/skyblock/dwarven/DwarvenHudConfigScreen.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/skyblock/shortcut/ShortcutsConfigScreen.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/skyblock/shortcut/ShortcutsConfigScreen.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/skyblock/dungeon/DungeonMapConfigScreen.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/utils/render/title/TitleContainerConfigScreen.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/config/SkyblockerConfigManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked through the config screen and it looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Moves to YACL for the config library!
Details
The Sonatype and Quilt repositories are also needed to retrieve YACL's dependencies
We also continue to use the old deprecated config api due to the new one being bugged as it can't deserialize maps.
Changes
Translation String Format
Since we're free to define the format of translations strings they should be updated after this PR (avoids major merge conflicts)
Additionally, some strings are now unused but have not yet been removed, the removal can happen with the string format change.