Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YACL Config #328

Merged
merged 10 commits into from Oct 1, 2023
Merged

YACL Config #328

merged 10 commits into from Oct 1, 2023

Conversation

AzureAaron
Copy link
Collaborator

@AzureAaron AzureAaron commented Sep 24, 2023

Moves to YACL for the config library!

Details

  • Maintains the same config file format (nothing gets reset)
  • We can move/relocate things in the UI without changing the file format :)
  • YACL offers the ability to add custom functionality for the UI if we want

The Sonatype and Quilt repositories are also needed to retrieve YACL's dependencies

We also continue to use the old deprecated config api due to the new one being bugged as it can't deserialize maps.

Changes

  • Dungeons and Dwarven Mines are their own tab
    • This makes them work easier and their big enough to be their own tab (Dwarven Mines should be renamed to Mining tbh)
  • The designs of some other tabs have been simplified a bit to work, minor change though
  • The translation strings for quick nav buttons 2-12 are now unused except for the title ones (they aren't needed now)
  • Buttons to access separate config screens have been added

Translation String Format

Since we're free to define the format of translations strings they should be updated after this PR (avoids major merge conflicts)

Additionally, some strings are now unused but have not yet been removed, the removal can happen with the string format change.

@AzureAaron AzureAaron added this to the update mc to 1.20.2 milestone Sep 24, 2023
@AzureAaron AzureAaron linked an issue Sep 24, 2023 that may be closed by this pull request
@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Sep 24, 2023
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look at the code. Didn't confirm the config screens, categories, and translations.

kevinthegreat1
kevinthegreat1 previously approved these changes Sep 28, 2023
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the config screen and it looks good.

kevinthegreat1
kevinthegreat1 previously approved these changes Sep 29, 2023
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AzureAaron AzureAaron merged commit 555161a into SkyblockerMod:master Oct 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change config library
3 participants