Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Protection #335

Merged
merged 3 commits into from Oct 4, 2023
Merged

Conversation

AzureAaron
Copy link
Collaborator

Ever felt like slot locking wasn't enough to protect your items? Ever accidentally almost tossed out that prized sword of yours? Or have you ever accidentally sold a precious item to the NPC (and maybe not gotten it back)?

Now meet /skyblocker protectItem!

When an item is protected it's safe from:

  • Being dropped while holding it, regardless of the slot being locked
  • Being dropped from picking it up in your inventory then clicking outside the screen
  • Being dropped via hovering over it and pressing the drop key
  • Being sold to the NPC
  • Being inserted into the salvaging menu

Now you'll never have to worry about your valued items!

@Julienraptor01
Copy link
Contributor

Can you trigger the action via a keybind ?
It would lock the item when hovering it or holding it in hand

@AzureAaron
Copy link
Collaborator Author

Can you trigger the action via a keybind ?
It would lock the item when hovering it or holding it in hand

This isn't really slot or item locking, intended to be applied for the long-term rather than short term

kevinthegreat1
kevinthegreat1 previously approved these changes Oct 4, 2023
@kevinthegreat1
Copy link
Collaborator

Wait, maybe ItemProtection could go in the item package?

@AzureAaron AzureAaron merged commit da657c4 into SkyblockerMod:master Oct 4, 2023
1 check passed
@AzureAaron AzureAaron deleted the item-protection branch October 6, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants